This is an archive of the discontinued LLVM Phabricator instance.

[dsymutil] Detangle DwarfLinker and move abstractions in their own implementation (NFC)
ClosedPublic

Authored by JDevlieghere on Jun 27 2018, 7:31 AM.

Details

Summary

This patch splits off some abstractions used by the dwarf linker in dsymutil and moves them into their own header and implementation files. This halves the number of LOC in DwarfLinker.cpp and makes it a lot easier to see what's going on where.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jun 27 2018, 7:31 AM

Assuming there are no other code changes, this seems like a good idea.

llvm/tools/dsymutil/DeclContext.cpp
3

this comment seems wrong?

llvm/tools/dsymutil/DeclContext.h
3

this comment seems wrong?

llvm/tools/dsymutil/DwarfStreamer.h
1

DwarfStreamer?

llvm/tools/dsymutil/LinkUtils.h
1

LinkUtils.

llvm/tools/dsymutil/MachOUtils.cpp
1

-*- C++ -*-

JDevlieghere marked 5 inline comments as done.
  • Fix ASCII art
llvm/tools/dsymutil/MachOUtils.cpp
1

Actually it's an implementation, so the extension should be updated rather than the language specifier :-)

  • Fixed extension: .h -> .cpp
friss accepted this revision.Jun 27 2018, 9:04 AM

If this sis really only moving code around, then this LGTM

This revision is now accepted and ready to land.Jun 27 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.