Page MenuHomePhabricator

UBSan blacklist workaround for bot timeouts
ClosedPublic

Authored by vlad.tsyrklevich on Jun 25 2018, 1:49 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

This looks very brittle. Any change to function signature, and good luck finding out why compilation is suddenly 5x slower.

WDYT about modifying the code generator to add no_sanitize attribute to the function?

vitalybuka accepted this revision.Jun 25 2018, 1:53 PM
This revision is now accepted and ready to land.Jun 25 2018, 1:53 PM
vitalybuka requested changes to this revision.Jun 25 2018, 1:55 PM

+1 for no_sanitize attribute

This revision now requires changes to proceed.Jun 25 2018, 1:55 PM

I guess, adding a few wildcards to the suppression to match only the function and/or class name would also be acceptable.

I guess, adding a few wildcards to the suppression to match only the function and/or class name would also be acceptable.

The reason I prefer the blacklist approach is that it doesn't bleed an aarch64-specific ubsan failure into common code generation routines.

  • Make blacklist entry more generic
eugenis accepted this revision.Jun 25 2018, 2:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2018, 2:33 PM
This revision was automatically updated to reflect the committed changes.