This is an archive of the discontinued LLVM Phabricator instance.

Add Triple::isMIPS()/isMIPS32()/isMIPS64(). NFC
ClosedPublic

Authored by arichardson on Jun 25 2018, 7:09 AM.

Details

Summary

There are quite a few if statements that enumerate all these cases. It gets
even worse in our fork of LLVM where we also have a Triple::cheri (which
is mips64 + CHERI instructions) and we had to update all if statements that
check for Triple::mips64 to also handle Triple::cheri. This patch helps to
reduce our diff to upstream and should also make some checks more readable.

Diff Detail

Event Timeline

arichardson created this revision.Jun 25 2018, 7:09 AM
atanasyan added inline comments.Jun 25 2018, 7:17 AM
lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp
31

Do you mean that we need to handle isMIPS64() case here? If so, in that case we satisfied by default values of PrivateGlobalPrefix and PrivateLocalPrefix.

arichardson marked an inline comment as done.

Remove old comment

lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp
31

Sorry, that was a stale comment, will remove.

This revision is now accepted and ready to land.Jun 25 2018, 8:29 AM
This revision was automatically updated to reflect the committed changes.