Page MenuHomePhabricator
Differential D48489

[MemDep] Use PhiValuesAnalysis to improve alias analysis results
ClosedPublic
Actions

Authored by john.brawn on Jun 22 2018, 9:57 AM.

Details

Reviewers
wmi
reames
efriedma
nlopes
davide
sebpop
Commits
rGcd5f37f3f100: [MemDep] Use PhiValuesAnalysis to improve alias analysis results
rL338384: [MemDep] Use PhiValuesAnalysis to improve alias analysis results
Summary

This is being done in order to make GVN able to better optimize certain inputs. MemDep doesn't use PhiValues directly, but does need to notifiy it when things get invalidated.

Diff Detail

Repository
rL LLVM

Event Timeline

john.brawn created this revision.Jun 22 2018, 9:57 AM
Herald added subscribers: steven_wu, eraman, mehdi_amini. · View Herald TranscriptJun 22 2018, 9:57 AM
john.brawn added a parent revision: D44564: [BasicAA] Use PhiValuesAnalysis if available when handling phi alias.Jun 22 2018, 9:57 AM
john.brawn mentioned this in D44564: [BasicAA] Use PhiValuesAnalysis if available when handling phi alias.
brzycki added a subscriber: brzycki.Jun 29 2018, 8:02 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptJun 29 2018, 8:02 AM
john.brawn updated this revision to Diff 154226.EditedJul 5 2018, 6:49 AM

Rebase on top of latest patch for D44564.

sebpop accepted this revision.Jul 27 2018, 12:16 PM
sebpop added a subscriber: sebpop.

Looks good to me. Thanks!

This revision is now accepted and ready to land.Jul 27 2018, 12:16 PM
Closed by commit rL338384: [MemDep] Use PhiValuesAnalysis to improve alias analysis results (authored by john.brawn). · Explain WhyJul 31 2018, 7:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
include/
llvm/
Analysis/
6 lines
lib/
Analysis/
17 lines
test/
Other/
5 lines
1 line
5 lines
3 lines
3 lines
3 lines
Transforms/
GVN/
PRE/
6 lines

Diff 158256

View Options

llvm/trunk/include/llvm/Analysis/MemoryDependenceAnalysis.h

Loading...
View Options

llvm/trunk/lib/Analysis/MemoryDependenceAnalysis.cpp

Loading...
View Options

llvm/trunk/test/Other/new-pm-defaults.ll

Loading...
View Options

llvm/trunk/test/Other/new-pm-lto-defaults.ll

Loading...
View Options

llvm/trunk/test/Other/new-pm-thinlto-defaults.ll

Loading...
View Options

llvm/trunk/test/Other/opt-O2-pipeline.ll

Loading...
View Options

llvm/trunk/test/Other/opt-O3-pipeline.ll

Loading...
View Options

llvm/trunk/test/Other/opt-Os-pipeline.ll

Loading...
View Options

llvm/trunk/test/Transforms/GVN/PRE/pre-after-rle.ll

Loading...