[MemDep] Use PhiValuesAnalysis to improve alias analysis results
ClosedPublic
Actions

Authored by john.brawn on Jun 22 2018, 9:57 AM.

Details

Reviewers

wmi
reames
efriedma
nlopes
davide
sebpop

Commits

rL338384: [MemDep] Use PhiValuesAnalysis to improve alias analysis results
rGcd5f37f3f100: [MemDep] Use PhiValuesAnalysis to improve alias analysis results

Summary

This is being done in order to make GVN able to better optimize certain inputs. MemDep doesn't use PhiValues directly, but does need to notifiy it when things get invalidated.

Diff Detail

Repository: rL LLVM

Event Timeline

john.brawn created this revision.Jun 22 2018, 9:57 AM

Herald added subscribers: steven_wu, eraman, mehdi_amini. · View Herald TranscriptJun 22 2018, 9:57 AM

john.brawn added a parent revision: D44564: [BasicAA] Use PhiValuesAnalysis if available when handling phi alias.Jun 22 2018, 9:57 AM

john.brawn mentioned this in D44564: [BasicAA] Use PhiValuesAnalysis if available when handling phi alias.

brzycki added a subscriber: brzycki.Jun 29 2018, 8:02 AM

Herald added a subscriber: dexonsmith. · View Herald TranscriptJun 29 2018, 8:02 AM

Rebase on top of latest patch for D44564.

Looks good to me. Thanks!

This revision is now accepted and ready to land.Jul 27 2018, 12:16 PM

Closed by commit rL338384: [MemDep] Use PhiValuesAnalysis to improve alias analysis results (authored by john.brawn, committed by ). · Explain WhyJul 31 2018, 7:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/include/llvm/Analysis/MemoryDependenceAnalysis.h (6 lines)
M			llvm/trunk/lib/Analysis/MemoryDependenceAnalysis.cpp (17 lines)
M			llvm/trunk/test/Other/new-pm-defaults.ll (5 lines)
M			llvm/trunk/test/Other/new-pm-lto-defaults.ll (1 line)
M			llvm/trunk/test/Other/new-pm-thinlto-defaults.ll (5 lines)
M			llvm/trunk/test/Other/opt-O2-pipeline.ll (3 lines)
M			llvm/trunk/test/Other/opt-O3-pipeline.ll (3 lines)
M			llvm/trunk/test/Other/opt-Os-pipeline.ll (3 lines)
M			llvm/trunk/test/Transforms/GVN/PRE/pre-after-rle.ll (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	152504			Jun 22 2018, 9:53 AM	★	★
Diff 2	154226			Jul 5 2018, 6:49 AM	★	★
Diff 3	158256	338383	rL338384	Jul 31 2018, 7:19 AM	★	★

Status	Author	Revision
Closed	john.brawn	D48489 [MemDep] Use PhiValuesAnalysis to improve alias analysis results
Closed	john.brawn	D44564 [BasicAA] Use PhiValuesAnalysis if available when handling phi alias
Closed	john.brawn	D44160 [GVN] Don't use the eliminated load as an available value in phi construction
Closed	john.brawn	D47893 Add a PhiValuesAnalysis pass to calculate the underlying values of phis