This is an archive of the discontinued LLVM Phabricator instance.

Differential D48363

[clang-format] Enable text proto formatting in common functions
ClosedPublic

Authored by krasimir on Jun 20 2018, 5:41 AM.

Details

Reviewers
djasper
Commits
rG42948e3c8fde: [clang-format] Enable text proto formatting in common functions
rC335595: [clang-format] Enable text proto formatting in common functions
rL335595: [clang-format] Enable text proto formatting in common functions
Summary

This enables text proto formatting in PARSE_TEXT_PROTO(R"(...)") and EqualsProto<...>(R"(...)").

Diff Detail

Event Timeline

krasimir created this revision.Jun 20 2018, 5:41 AM
Harbormaster completed remote builds in B19505: Diff 152071.Jun 20 2018, 5:41 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptJun 20 2018, 5:41 AM
krasimir edited the summary of this revision. (Show Details)Jun 26 2018, 1:41 AM
krasimir added a reviewer: djasper.
djasper accepted this revision.Jun 26 2018, 2:03 AM

Looks good.

This revision is now accepted and ready to land.Jun 26 2018, 2:03 AM
Closed by commit rL335595: [clang-format] Enable text proto formatting in common functions (authored by krasimir). · Explain WhyJun 26 2018, 5:05 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 26 2018, 5:05 AM

Revision Contents

PathSize
lib/
Format/
5 lines

Diff 152071

lib/Format/Format.cpp

Show First 20 Lines • Show All 768 Lines • ▼ Show 20 Lines GoogleStyle.RawStringFormats = {
/*Delimiters=*/ /*Delimiters=*/
{ {
"pb", "pb",
"PB", "PB",
"proto", "proto",
"PROTO", "PROTO",
}, },
/*EnclosingFunctionNames=*/ /*EnclosingFunctionNames=*/
{}, {
"PARSE_TEXT_PROTO",
"EqualsProto",
},
/*CanonicalDelimiter=*/"", /*CanonicalDelimiter=*/"",
/*BasedOnStyle=*/"google", /*BasedOnStyle=*/"google",
}, },
}; };
GoogleStyle.SpacesBeforeTrailingComments = 2; GoogleStyle.SpacesBeforeTrailingComments = 2;
GoogleStyle.Standard = FormatStyle::LS_Auto; GoogleStyle.Standard = FormatStyle::LS_Auto;
GoogleStyle.PenaltyReturnTypeOnItsOwnLine = 200; GoogleStyle.PenaltyReturnTypeOnItsOwnLine = 200;
▲ Show 20 Lines • Show All 1,450 Lines • Show Last 20 Lines