This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] [CMake] Convert paths to the right form in standalone builds on Windows
ClosedPublic

Authored by mstorsjo on Jun 20 2018, 2:57 AM.

Details

Summary

The paths output from llvm-config --cmakedir and from clang --print-libgcc-file-name can contain backslashes, while CMake can't handle the paths in this form.

This matches what compiler-rt already does (since SVN r203789 and r293195).

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Jun 20 2018, 2:57 AM
smeenai accepted this revision.Jun 20 2018, 12:32 PM
smeenai added a subscriber: smeenai.

LGTM with the same comments as D48356 (add quotes, and is the translation for LLVM_BINARY_DIR necessary?)

This revision is now accepted and ready to land.Jun 20 2018, 12:32 PM
This revision was automatically updated to reflect the committed changes.