The paths output from llvm-config --cmakedir and from clang --print-libgcc-file-name can contain backslashes, while CMake can't handle the paths in this form.
This matches what compiler-rt already does (since SVN r203789 and r293195).
Paths
| Differential D48355
[libcxxabi] [CMake] Convert paths to the right form in standalone builds on Windows ClosedPublic Authored by mstorsjo on Jun 20 2018, 2:57 AM.
Details Summary The paths output from llvm-config --cmakedir and from clang --print-libgcc-file-name can contain backslashes, while CMake can't handle the paths in this form. This matches what compiler-rt already does (since SVN r203789 and r293195).
Diff Detail
Event TimelineComment Actions LGTM with the same comments as D48356 (add quotes, and is the translation for LLVM_BINARY_DIR necessary?) This revision is now accepted and ready to land.Jun 20 2018, 12:32 PM Closed by commit rL335171: [CMake] Convert paths to the right form in standalone builds on Windows (authored by mstorsjo). · Explain WhyJun 20 2018, 2:05 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 152158 libcxxabi/trunk/cmake/Modules/HandleCompilerRT.cmake
libcxxabi/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake
|