Looks like we don't add tests for this, but I am planning on using it in D48128
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
include/llvm/IR/PatternMatch.h | ||
---|---|---|
1206 ↗ | (On Diff #151704) | Are you sure you want the pointer operand, and not the value being stored? (Or maybe both?) |
Comment Actions
Thanks for the suggestions:
- added unittests,
- now storing both the pointer and value operand (looks most convenient to me).
unittests/IR/PatternMatch.cpp | ||
---|---|---|
403 ↗ | (On Diff #151728) | Can you remove these, just using m_Value() as the above tests? Or maybe better to test that they are the correct values (i.e EXPECT_EQ(Alloca, MatchStorePointer);) |
Comment Actions
LGTM. This looks simple enough. Perhaps wait enough for anyone on a different time zone to object.
unittests/IR/PatternMatch.cpp | ||
---|---|---|
411–417 ↗ | (On Diff #151902) | Can you add a basic sanity test to show that it works with m_Specific(), too? |