Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 19411 Build 19411: arc lint + arc unit
Event Timeline
Comment Actions
With the three whitespace issues fixed up, LGTM.
(I am also observing that the version check in ThreadDescriptorSize is Linux-only (minus Android), such that the cpp guards !SANITIZER_FREEBSD && !SANITIZER_ANDROID && ... will be broad enough.)
Tested with -m32 -fsanitize=address glibc 2.27.0 (with #define CHECK_GET_TLS_STATIC_INFO_VERSION 1) and glibc 2.23.0.
compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cc | ||
---|---|---|
210 | style nitpicks: remove the double spaces after ? in the lines above and in sizeof(kGLibC) - 1. |
style nitpicks: remove the double spaces after ? in the lines above and in sizeof(kGLibC) - 1.