This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] A mechanism to add target-specific functionality.
ClosedPublic

Authored by courbet on Jun 15 2018, 2:17 AM.

Diff Detail

Event Timeline

courbet created this revision.Jun 15 2018, 2:17 AM
courbet updated this revision to Diff 151473.Jun 15 2018, 2:19 AM

Add missing file.

gchatelet added inline comments.Jun 19 2018, 12:40 AM
tools/llvm-exegesis/lib/Target.cpp
31

"Target has already been registered"

tools/llvm-exegesis/lib/Uops.cpp
87

Is the code to generate the memory Operands in?

tools/llvm-exegesis/llvm-exegesis.cpp
127

You shouldn't need the guard.

unittests/tools/llvm-exegesis/X86/TargetTest.cpp
22

EXPECT_THAT(..., NotNull()) ?

courbet updated this revision to Diff 151863.Jun 19 2018, 1:11 AM
courbet marked 3 inline comments as done.

address review comments

tools/llvm-exegesis/lib/Uops.cpp
87

Thanks for the catch, I did not want to submit this.

tools/llvm-exegesis/llvm-exegesis.cpp
127

It's needed in case the target is not supported or not built for.

gchatelet accepted this revision.Jun 19 2018, 1:15 AM
This revision is now accepted and ready to land.Jun 19 2018, 1:15 AM
This revision was automatically updated to reflect the committed changes.