Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
One small comment, LGTM otherwise.
docs/TestingGuide.rst | ||
---|---|---|
464 | What about suggesting an alternative like: Use ``rm -rf %t && mkdir %t`` instead if a temporary directory is necessary. Perhaps that could even replace the Shouldn't be used, because [reason] sentence if brevity is desired. |
Comment Actions
%T should also be deprecated (or removed) below, where it's documented incorrectly:
https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions
Comment Actions
%T should also be deprecated (or removed) below, where it's documented incorrectly:
https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions
Good catch. https://reviews.llvm.org/D48842.
What about suggesting an alternative like:
Perhaps that could even replace the Shouldn't be used, because [reason] sentence if brevity is desired.