Page MenuHomePhabricator

[llvm] Document "%T" as deprecated in TestingGuide.rst
ClosedPublic

Authored by kubamracek on Jun 14 2018, 12:56 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek created this revision.Jun 14 2018, 12:56 PM

One small comment, LGTM otherwise.

docs/TestingGuide.rst
464 ↗(On Diff #151405)

What about suggesting an alternative like:

Use ``rm -rf %t && mkdir %t`` instead if a temporary directory is necessary.

Perhaps that could even replace the Shouldn't be used, because [reason] sentence if brevity is desired.

Lekensteyn accepted this revision.Jun 14 2018, 1:24 PM
This revision is now accepted and ready to land.Jun 14 2018, 1:24 PM
This revision was automatically updated to reflect the committed changes.
jdenny added a subscriber: jdenny.Jul 2 2018, 9:37 AM

%T should also be deprecated (or removed) below, where it's documented incorrectly:

https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions

%T should also be deprecated (or removed) below, where it's documented incorrectly:
https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions

Good catch. https://reviews.llvm.org/D48842.