This is an archive of the discontinued LLVM Phabricator instance.

Differential D48152

[CUDA] Add tests that, in C++14 mode, min/max are constexpr.
ClosedPublic

Authored by jlebar on Jun 13 2018, 2:30 PM.

Details

Reviewers
rsmith
tra
Commits
rOLDT336030: [CUDA] Add tests that, in C++14 mode, min/max are constexpr.
rL336030: [CUDA] Add tests that, in C++14 mode, min/max are constexpr.

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar created this revision.Jun 13 2018, 2:30 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 13 2018, 2:30 PM
Harbormaster completed remote builds in B19309: Diff 151249.Jun 13 2018, 2:30 PM
jlebar added a parent revision: D48151: [CUDA] Make __host__/__device__ min/max overloads constexpr in C++14..Jun 13 2018, 2:31 PM
tra accepted this revision.Jun 13 2018, 3:18 PM
This revision is now accepted and ready to land.Jun 13 2018, 3:18 PM
Closed by commit rL336030: [CUDA] Add tests that, in C++14 mode, min/max are constexpr. (authored by jlebar). · Explain WhyJun 29 2018, 5:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test-suite/
trunk/
External/
CUDA/
4 lines

Diff 153603

test-suite/trunk/External/CUDA/algorithm.cu

Show All 36 Lines#if __cplusplus >= 201402L && STDLIB_VERSION >= 2014
assert(std::greater<int>()(1, 0)); assert(std::greater<int>()(1, 0));
assert(std::min({5, 1, 10}) == 1); assert(std::min({5, 1, 10}) == 1);
assert(std::max({5, 1, 10}, std::less<int>()) == 10); assert(std::max({5, 1, 10}, std::less<int>()) == 10);
assert(std::minmax(1, 0).first == 0); assert(std::minmax(1, 0).first == 0);
assert(std::minmax(1, 0).second == 1); assert(std::minmax(1, 0).second == 1);
assert(std::minmax({0, 10, -10, 100}, std::less<int>()).first == -10); assert(std::minmax({0, 10, -10, 100}, std::less<int>()).first == -10);
assert(std::minmax({0, 10, -10, 100}, std::less<int>()).second == 100); assert(std::minmax({0, 10, -10, 100}, std::less<int>()).second == 100);
constexpr auto min = std::min(1, 2);
constexpr auto max = std::max(1, 2);
#endif #endif
} }
// Same tests as cpp14_tests, but from a host-device context. // Same tests as cpp14_tests, but from a host-device context.
__host__ __device__ void cpp14_tests_hd() { __host__ __device__ void cpp14_tests_hd() {
#if __cplusplus >= 201402L && STDLIB_VERSION >= 2014 #if __cplusplus >= 201402L && STDLIB_VERSION >= 2014
assert(std::greater<int>()(1, 0)); assert(std::greater<int>()(1, 0));
assert(std::min({5, 1, 10}) == 1); assert(std::min({5, 1, 10}) == 1);
assert(std::max({5, 1, 10}, std::less<int>()) == 10); assert(std::max({5, 1, 10}, std::less<int>()) == 10);
assert(std::minmax(1, 0).first == 0); assert(std::minmax(1, 0).first == 0);
assert(std::minmax(1, 0).second == 1); assert(std::minmax(1, 0).second == 1);
assert(std::minmax({0, 10, -10, 100}, std::less<int>()).first == -10); assert(std::minmax({0, 10, -10, 100}, std::less<int>()).first == -10);
assert(std::minmax({0, 10, -10, 100}, std::less<int>()).second == 100); assert(std::minmax({0, 10, -10, 100}, std::less<int>()).second == 100);
constexpr auto min = std::min(1, 2);
constexpr auto max = std::max(1, 2);
#endif #endif
} }
__global__ void kernel() { __global__ void kernel() {
min(); min();
min_hd(); min_hd();
max(); max();
max_hd(); max_hd();
Show All 29 Lines