Page MenuHomePhabricator

[analyzer] Fix offset overflow check in MemRegion

Authored by george.karpenkov on Jun 13 2018, 11:09 AM.

Diff Detail


Event Timeline

NoQ accepted this revision.Jun 13 2018, 11:32 AM

Aha, ok, so Add and Mul were swapped in the pre-patch code, and the result was then discarded and recomputed correctly, but overflow checks didn't fire. Makes sense :)

This one looks as if it'd need a rebase because previous patches in the stack change the API that's being removed here.

This revision is now accepted and ready to land.Jun 13 2018, 11:32 AM
This revision was automatically updated to reflect the committed changes.