[analyzer] Do not crash in the visitor when the function is given more arguments than it has parameters

[george.karpenkov]

Summary

rdar://40335545

[NoQ]

I guess this deserves at least a sink, maybe a checker.

clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

if (const auto *CCall = dyn_cast<CXXConstructorCall>(Call)) {
       if (RegionOfInterest->isSubRegionOf(ThisRegion)
           && !CCall->getDecl()->isImplicit()
           && !isRegionOfInterestModifiedInFrame(N))
         return notModifiedInConstructorDiagnostics(Ctx, SM, PP, *CallExitLoc,
                                                    CCall, ThisRegion);
     }
 
     ArrayRef<ParmVarDecl *> parameters = getCallParameters(Call);
-    for (unsigned I = 0, E = Call->getNumArgs(); I != E; ++I) {
+    for (unsigned I = 0; I < Call->getNumArgs() && I < parameters.size(); ++I) {
       const ParmVarDecl *PVD = parameters[I];
       SVal S = Call->getArgSVal(I);
       unsigned IndirectionLevel = 1;
       QualType T = PVD->getType();
       while (const MemRegion *R = S.getAsRegion()) {
         if (RegionOfInterest->isSubRegionOf(R)
             && !isPointerToConst(PVD->getType())) {
 

clang/test/Analysis/diagnostics/no-store-func-path-notes.cpp

 int usepointerreference() {
   S2 s;
   S2* p = &s;
   pointerreference(p); //expected-note{{Calling 'pointerreference'}}
                          //expected-note@-1{{Returning from 'pointerreference'}}
   return s.x; // expected-warning{{Undefined or garbage value returned to caller}}
               // expected-note@-1{{Undefined or garbage value returned to caller}}
 }
+
+void *has_no_argument_and_returns_null(void) {
+  return 0;
+}
+
+void rdar40335545() {
+    int local;
+    void (*takes_int_ptr_argument)(int *) = (void (*)(int*))has_no_argument_and_returns_null;
+
+    takes_int_ptr_argument(&local); // no-crash
+
+    int useLocal = local;
+    (void)useLocal;
+}