This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] [NFC] Remove "removeInvalidation" from visitor API
ClosedPublic

Authored by george.karpenkov on Jun 11 2018, 12:08 PM.

Details

Summary

removeInvalidation is a very problematic API, as it makes suppression order-dependent.
Moreover, it was used only once, and could be rewritten in a much cleaner way.

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ accepted this revision.Jun 12 2018, 12:25 PM

Can confirm - that was a nightmare to debug.

This revision is now accepted and ready to land.Jun 12 2018, 12:25 PM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.