This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Fix unhandled error.
ClosedPublic

Authored by gchatelet on Jun 11 2018, 6:35 AM.

Reviewers

courbet
RKSimon

Commits

Summary

Fixing an unhandled error when calling writeYaml.

Repository

rL LLVM

Build Status

Buildable 19169
Build 19169: arc lint + arc unit

Removed LLVM_NODISCARD from InstructionBenchmark IO functions since llvm::Error is already marked as LLVM_NODISCARD.

Removing unnecessary header.

Too bad clang does not catch this in loops.

This revision is now accepted and ready to land.Jun 11 2018, 6:59 AM

Thanks - this fixes PR37759

This revision was automatically updated to reflect the committed changes.

Path

Size

tools/

llvm-exegesis/

2 lines

Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Lines	void benchmarkMain() {
// Write to standard output if file is not set.		// Write to standard output if file is not set.
if (BenchmarkFile.empty())		if (BenchmarkFile.empty())
BenchmarkFile = "-";		BenchmarkFile = "-";

const BenchmarkResultContext Context = getBenchmarkResultContext(State);		const BenchmarkResultContext Context = getBenchmarkResultContext(State);
std::vector<InstructionBenchmark> Results = ExitOnErr(Runner->run(		std::vector<InstructionBenchmark> Results = ExitOnErr(Runner->run(
GetOpcodeOrDie(State.getInstrInfo()), Filter, NumRepetitions));		GetOpcodeOrDie(State.getInstrInfo()), Filter, NumRepetitions));
for (InstructionBenchmark &Result : Results)		for (InstructionBenchmark &Result : Results)
Result.writeYaml(Context, BenchmarkFile);		ExitOnErr(Result.writeYaml(Context, BenchmarkFile));

exegesis::pfm::pfmTerminate();		exegesis::pfm::pfmTerminate();
}		}

// Prints the results of running analysis pass `Pass` to file `OutputFilename`		// Prints the results of running analysis pass `Pass` to file `OutputFilename`
// if OutputFilename is non-empty.		// if OutputFilename is non-empty.
template <typename Pass>		template <typename Pass>
static void maybeRunAnalysis(const Analysis &Analyzer, const std::string &Name,		static void maybeRunAnalysis(const Analysis &Analyzer, const std::string &Name,
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines