Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Thanks for adding some test coverage! Few things that might be able to be simplified before committing.
unittests/ADT/SmallSetTest.cpp | ||
---|---|---|
34–35 | not sure these two cases are worth testing separately - even though 4 is technically a boundary value, the set was never passed the value 4 so it seems just as likely to be buggily present as 99 does? (similar feedback on similar testing in the other cases, I think) |
unittests/ADT/SmallSetTest.cpp | ||
---|---|---|
34–35 | Yep, I'll drop the 99 case here and at the other places, thanks! |
not sure these two cases are worth testing separately - even though 4 is technically a boundary value, the set was never passed the value 4 so it seems just as likely to be buggily present as 99 does? (similar feedback on similar testing in the other cases, I think)