Page MenuHomePhabricator

[SmallSet] Add some simple unit tests.
ClosedPublic

Authored by fhahn on Jun 8 2018, 6:11 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Jun 8 2018, 6:11 AM
dblaikie accepted this revision.Jun 8 2018, 11:14 AM

Thanks for adding some test coverage! Few things that might be able to be simplified before committing.

unittests/ADT/SmallSetTest.cpp
34–35 ↗(On Diff #150501)

not sure these two cases are worth testing separately - even though 4 is technically a boundary value, the set was never passed the value 4 so it seems just as likely to be buggily present as 99 does? (similar feedback on similar testing in the other cases, I think)

This revision is now accepted and ready to land.Jun 8 2018, 11:14 AM
fhahn added inline comments.Jun 8 2018, 11:30 AM
unittests/ADT/SmallSetTest.cpp
34–35 ↗(On Diff #150501)

Yep, I'll drop the 99 case here and at the other places, thanks!

This revision was automatically updated to reflect the committed changes.