Page MenuHomePhabricator

[mips] Fix spill slot for mips3, n64 abi
ClosedPublic

Authored by abeserminji on Jun 8 2018, 4:28 AM.

Details

Summary

When program is compiled for mips3 with n64 abi, wrong register class is used for creating an emergency spill slot.
This patch fixes the correct register class to be chosen.

This resolves PR35859.

Thanks to John Baldwin for reporting the issue!

Diff Detail

Repository
rL LLVM

Event Timeline

abeserminji created this revision.Jun 8 2018, 4:28 AM
sdardis accepted this revision.Jun 8 2018, 5:01 AM

Edit the summary so that rather that it says:

This resolves PR35859.

Thanks to John Baldwin for reporting the issue!

Otherwise LGTM.

test/CodeGen/Mips/mips3-spill-slot.ll
5 ↗(On Diff #150473)

Add a line referencing the PR that this fixes.

This revision is now accepted and ready to land.Jun 8 2018, 5:01 AM
sdardis added inline comments.Jun 8 2018, 5:02 AM
lib/Target/Mips/MipsSEFrameLowering.cpp
885–886 ↗(On Diff #150473)

Update the comment here so that it matches the code below.

abeserminji edited the summary of this revision. (Show Details)Jun 11 2018, 6:07 AM
abeserminji marked 2 inline comments as done.

Comments addressed.

This revision was automatically updated to reflect the committed changes.