This is an archive of the discontinued LLVM Phabricator instance.

Move VersionTuple from clang/Basic to llvm/Support, clang part
ClosedPublic

Authored by labath on Jun 7 2018, 8:29 AM.

Details

Summary

This kind of functionality is useful to other project apart from clang.
LLDB works with version numbers a lot, but it does not have a convenient
abstraction for this. Moving this class to a lower level library allows
it to be freely used within LLDB.

Since this class is used in a lot of places, and it used to be in the
clang namespace, it seemed appropriate to add it to the list of adopted
classes in LLVM.h to avoid prefixing all uses with "llvm::".

Diff Detail

Event Timeline

labath created this revision.Jun 7 2018, 8:29 AM
erik.pilkington accepted this revision.Jun 8 2018, 6:21 AM

LGTM. Looks like LLDB has some uses of VersionTuple, you should fix those to #include the LLVM version before removing the header here. (Or, better yet, do it all atomically with the monorepo as @zturner suggested)

This revision is now accepted and ready to land.Jun 8 2018, 6:21 AM
labath closed this revision.Jun 11 2018, 4:37 AM

Committed as a part of D47887 via monorepo.

lib/Basic/ObjCRuntime.cpp