Page MenuHomePhabricator

DebugNamesDWARFIndex: Implement GetFunctions method
ClosedPublic

Authored by labath on Jun 7 2018, 7:12 AM.

Details

Summary

This patch implements the non-regex variant of GetFunctions. To share
more code with the Apple implementation, I've extracted the common
filtering code from that class into a utility function on the DWARFIndex
base class.

The new implementation also searching the accelerator table multiple
times -- previously it could happen that the apple table would return
the same die more than once if one specified multiple search flags in
name_type_mask. This way, I separate table iteration from filtering, and
so we can be sure each die is inserted at most once.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jun 7 2018, 7:12 AM
clayborg accepted this revision.Jun 7 2018, 1:19 PM
This revision is now accepted and ready to land.Jun 7 2018, 1:19 PM
This revision was automatically updated to reflect the committed changes.