Fix up Info.plist when building LLDB.framework with CMake

[xiaobai]

Summary

We weren't using the Info.plist template in resources previously.
When using that template, some of the key's values weren't being populated
because some variables were not being defined. In one case, CMake didn't
like the substring expansion syntax of CFBundleIdentifier so I got rid of that.

[sas]

source/API/CMakeLists.txt

184

Hardcoding this here isn't ideal. Where did you get this number from? Is there a way to fetch it from a single location?

[clayborg]

source/API/CMakeLists.txt

184

Currently the apple generic versioning is used and the value for this is grabbed from CURRENT_PROJECT_VERSION in the Xcode project in lldb.xcodeproj/project.pbxproj. We will need to let people know that they will need to update this variable from now on.

184

It was hardcoded into the Xcode project before. The numbers would be manually bumped by using "agvtool bump -all". That would update the Xcode project and a few plist files. Feel free to try running that from the root LLDB directory to see all files that get updated, then revert once you see what changed.

[xiaobai]

source/API/CMakeLists.txt

184

In the meantime, is hardcoding this version an acceptable thing to do? Additionally, this value is actually hardcoded in the Info.plist as CFBundleVersion, but filled in with CURRENT_PROJECT_VERSION in CFBundleShortVersionString. That seems kind of clowny.

[xiaobai]

Friendly ping!

[sas]

LGTM for now.

[clayborg]

Looks good to me as long as Xcode still produces the same Info.plist in its LLDB.framework after your changes.

[xiaobai]

Rebasing this commit after my framework refactor

resources/LLDB-Info.plist

 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
   <key>CFBundleDevelopmentRegion</key>
   <string>English</string>
   <key>CFBundleExecutable</key>
   <string>${EXECUTABLE_NAME}</string>
   <key>CFBundleIdentifier</key>
-  <string>com.apple.${PRODUCT_NAME:rfc1034identifier}.framework</string>
+  <string>com.apple.${PRODUCT_NAME}.framework</string>
   <key>CFBundleInfoDictionaryVersion</key>
   <string>6.0</string>
   <key>CFBundlePackageType</key>
   <string>FMWK</string>
   <key>CFBundleShortVersionString</key>
   <string>1.${CURRENT_PROJECT_VERSION}</string>
   <key>CFBundleSignature</key>
   <string>????</string>
   <key>CFBundleVersion</key>
   <string>360.99.0</string>
   <key>CFBundleName</key>
   <string>${EXECUTABLE_NAME}</string>
 </dict>
 </plist>

source/API/CMakeLists.txt

add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders/${basename}
                        COMMAND ${CMAKE_COMMAND} -E copy ${header} ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders/${basename})
     list(APPEND framework_headers ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders/${basename})
   endforeach()
 
   add_custom_target(lldb-framework-headers DEPENDS ${framework_headers}
                     COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders ${LLDB_VERSION})
   add_dependencies(liblldb lldb-framework-headers)
 
+  set(PRODUCT_NAME "LLDB")
+  set(EXECUTABLE_NAME "LLDB")
+  set(CURRENT_PROJECT_VERSION "360.99.0")
   set_target_properties(liblldb PROPERTIES
     OUTPUT_NAME LLDB
     FRAMEWORK On
     FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}
+    MACOSX_FRAMEWORK_INFO_PLIST ${LLDB_SOURCE_DIR}/resources/LLDB-Info.plist
     LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${LLDB_FRAMEWORK_INSTALL_DIR}
     PUBLIC_HEADER "${framework_headers}")
 
   if(NOT IOS)
     if (NOT LLDB_BUILT_STANDALONE)
       add_dependencies(liblldb clang-headers)
     endif()
     add_custom_command(TARGET liblldb POST_BUILD