This is an archive of the discontinued LLVM Phabricator instance.

Differential D47668

[Driver][Fuchsia] Pass LTO flags to linker
ClosedPublic

Authored by phosek on Jun 1 2018, 5:53 PM.

Details

Reviewers
mcgrathr
juliehockett
Commits
rG03eece728f55: [Driver][Fuchsia] Pass LTO flags to linker
rC333979: [Driver][Fuchsia] Pass LTO flags to linker
rL333979: [Driver][Fuchsia] Pass LTO flags to linker
Summary

Even though we use lld by default for Fuchsia, we use Gold plugin
arguments like all other drivers as lld supports Gold plugin options.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jun 1 2018, 5:53 PM
Herald added subscribers: cfe-commits, inglorion. · View Herald TranscriptJun 1 2018, 5:53 PM
mcgrathr accepted this revision.Jun 4 2018, 1:24 PM

lgtm

This revision is now accepted and ready to land.Jun 4 2018, 1:24 PM
Closed by commit rL333979: [Driver][Fuchsia] Pass LTO flags to linker (authored by phosek). · Explain WhyJun 4 2018, 6:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 4 2018, 6:55 PM

Revision Contents

PathSize
cfe/
trunk/
lib/
Driver/
ToolChains/
6 lines
test/
Driver/
13 lines

Diff 149893

cfe/trunk/lib/Driver/ToolChains/Fuchsia.cpp

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nostartfiles)) {
} }
} }
Args.AddAllArgs(CmdArgs, options::OPT_L); Args.AddAllArgs(CmdArgs, options::OPT_L);
Args.AddAllArgs(CmdArgs, options::OPT_u); Args.AddAllArgs(CmdArgs, options::OPT_u);
ToolChain.AddFilePathLibArgs(Args, CmdArgs); ToolChain.AddFilePathLibArgs(Args, CmdArgs);
if (D.isUsingLTO()) {
assert(!Inputs.empty() && "Must have at least one input.");
AddGoldPlugin(ToolChain, Args, CmdArgs, Output, Inputs[0],
D.getLTOMode() == LTOK_Thin);
}
addSanitizerRuntimes(ToolChain, Args, CmdArgs); addSanitizerRuntimes(ToolChain, Args, CmdArgs);
AddLinkerInputs(ToolChain, Inputs, Args, CmdArgs, JA); AddLinkerInputs(ToolChain, Inputs, Args, CmdArgs, JA);
if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs)) { if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs)) {
if (Args.hasArg(options::OPT_static)) if (Args.hasArg(options::OPT_static))
CmdArgs.push_back("-Bdynamic"); CmdArgs.push_back("-Bdynamic");
▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/fuchsia.c

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines
// CHECK-SCUDO-AARCH64: "-pie" // CHECK-SCUDO-AARCH64: "-pie"
// CHECK-SCUDO-AARCH64: "{{.*[/\\]}}libclang_rt.scudo-aarch64.so" // CHECK-SCUDO-AARCH64: "{{.*[/\\]}}libclang_rt.scudo-aarch64.so"
// RUN: %clang %s -### --target=x86_64-fuchsia \ // RUN: %clang %s -### --target=x86_64-fuchsia \
// RUN: -fsanitize=scudo -fPIC -shared 2>&1 \ // RUN: -fsanitize=scudo -fPIC -shared 2>&1 \
// RUN: | FileCheck %s -check-prefix=CHECK-SCUDO-SHARED // RUN: | FileCheck %s -check-prefix=CHECK-SCUDO-SHARED
// CHECK-SCUDO-SHARED: "-fsanitize=safe-stack,scudo" // CHECK-SCUDO-SHARED: "-fsanitize=safe-stack,scudo"
// CHECK-SCUDO-SHARED: "{{.*[/\\]}}libclang_rt.scudo-x86_64.so" // CHECK-SCUDO-SHARED: "{{.*[/\\]}}libclang_rt.scudo-x86_64.so"
// RUN: %clang %s -### --target=aarch64-fuchsia \
// RUN: -O3 -flto -mcpu=cortex-a53 2>&1 \
// RUN: | FileCheck %s -check-prefix=CHECK-LTO
// CHECK-LTO: "-plugin-opt=mcpu=cortex-a53"
// CHECK-LTO: "-plugin-opt=O3"
// RUN: %clang %s -### --target=x86_64-fuchsia \
// RUN: -flto=thin -flto-jobs=8 2>&1 \
// RUN: | FileCheck %s -check-prefix=CHECK-THINLTO
// CHECK-THINLTO: "-plugin-opt=mcpu=x86-64"
// CHECK-THINLTO: "-plugin-opt=thinlto"
// CHECK-THINLTO: "-plugin-opt=jobs=8"