This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Hide new Wasm EH behind its feature flag
ClosedPublic

Authored by aheejin on May 31 2018, 5:48 PM.

Details

Summary

clang's current wasm EH implementation is a non-MVP feature in progress.
We had a -mexception-handling wasm feature but were not using it. This
patch hides the non-MVP wasm EH behind a flag, so it does not affect
other code for now.

Diff Detail

Repository
rC Clang

Event Timeline

aheejin created this revision.May 31 2018, 5:48 PM
dschuff accepted this revision.May 31 2018, 5:51 PM
This revision is now accepted and ready to land.May 31 2018, 5:51 PM
aheejin updated this revision to Diff 149386.May 31 2018, 6:04 PM
  • Add a missing conditional statement. I'll still assume this as accepted
This revision was automatically updated to reflect the committed changes.
sbc100 added inline comments.May 31 2018, 7:40 PM
lib/CodeGen/CGException.cpp
322

If the triple can be derived from target why not just pass that target?

aheejin marked an inline comment as done.Jun 1 2018, 12:52 AM
aheejin added inline comments.
lib/CodeGen/CGException.cpp
322

Done in D47620. Thanks!