Page MenuHomePhabricator

[ScopInfo] Update Scop::addUserContext() to C++ interface
ClosedPublic

Authored by cs15btech11044 on May 27 2018, 11:00 PM.

Details

Summary

This patch updates Scop::addUserContext() function to the new C++ interface and replaces the auto keyword with explicit type wherever used in this function.

Diff Detail

Repository
rL LLVM

Event Timeline

grosser requested changes to this revision.May 27 2018, 11:03 PM

Very nice!

lib/Analysis/ScopInfo.cpp
2116 ↗(On Diff #148776)

Drop the manage(release()) pattern. This is not needed. Just say getParamSpace().

2131 ↗(On Diff #148776)

LLVM coding conventions prefers explicit types. As you already change this line and this is a mechanical change, I suggest to update this as well (please update commit message / summary to mention this).

This revision now requires changes to proceed.May 27 2018, 11:03 PM

Updates made to this differential:

  1. Removed manage(release) pattern in this diff
  2. Replaced auto keyword with explicit type wherever necessary.
grosser requested changes to this revision.May 27 2018, 11:32 PM

This looks good. Please also update the summary / commit message.

This revision now requires changes to proceed.May 27 2018, 11:32 PM
cs15btech11044 edited the summary of this revision. (Show Details)May 27 2018, 11:39 PM
grosser accepted this revision.May 28 2018, 12:37 AM

This LGTM.

This revision is now accepted and ready to land.May 28 2018, 12:37 AM
This revision was automatically updated to reflect the committed changes.

Committed. These changes are very useful. Thanks!