Page MenuHomePhabricator

[Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.
ClosedPublic

Authored by pgousseau on May 25 2018, 8:17 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

pgousseau created this revision.May 25 2018, 8:17 AM

LGTM with the indicated test tweak, but best if @filcab also takes a look.

lib/Driver/ToolChains/PS4CPU.cpp
87 ↗(On Diff #148609)

Don't bother with braces for a one-line if body.

test/Driver/fsanitize.c
624 ↗(On Diff #148609)

Repeat this NOT line before the new check? to preserve the property described in the comment.

filcab added a comment.Jun 6 2018, 4:40 AM

I have a minor nit + what Paul mentioned (missing a -NOT check). Otherwise LGTM.

lib/Driver/ToolChains/Clang.cpp
3690 ↗(On Diff #148609)

Nit: PGO, coverage, or sanitizers

pgousseau updated this revision to Diff 150124.Jun 6 2018, 7:02 AM

Updated patch with requested changes.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 6 2018, 7:08 AM
This revision was automatically updated to reflect the committed changes.