Page MenuHomePhabricator

[clang-format] Break template declarations followed by comments
ClosedPublic

Authored by krasimir on May 23 2018, 6:49 AM.

Details

Summary

This patch fixes two bugs in clang-format where the template wrapper doesn't skip over
comments causing a long template declaration to not be split into multiple lines.
These were latent and exposed by r332436.

Diff Detail

Repository
rL LLVM

Event Timeline

krasimir created this revision.May 23 2018, 6:49 AM
sammccall accepted this revision.May 23 2018, 7:06 AM

Thanks for chasing this, good detective work!
Changes look plausible and tests are nice, so LG assuming you know what you're doing. If you're unsure, Manuel will give you better advice than me :)

This revision is now accepted and ready to land.May 23 2018, 7:06 AM
This revision was automatically updated to reflect the committed changes.