This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Fix libomptarget/test/CMakeLists.txt
ClosedPublic

Authored by azharudd on May 22 2018, 1:14 PM.

Download Raw Diff

Details

Reviewers

jlpeyton
AndreyChurbanov
Hahnfeld

Commits

rG6712b8675bdc: [cmake] Fix libomptarget/test/CMakeLists.txt
rOMP337133: [cmake] Fix libomptarget/test/CMakeLists.txt
rL337133: [cmake] Fix libomptarget/test/CMakeLists.txt

Summary

Should be variable name instead of variable reference. If the variable is
somehow unset, it messes up the if condition expression and causes a CMake
error.

Diff Detail

Repository: rL LLVM

Event Timeline

azharudd created this revision.May 22 2018, 1:14 PM

Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptMay 22 2018, 1:14 PM

You are absolutely right, thanks for spotting this!

This revision is now accepted and ready to land.May 25 2018, 8:56 AM

Hahnfeld mentioned this in D47224: [cmake] Guard another instance where symlinks are being created.May 25 2018, 8:57 AM

Closed by commit rL337133: [cmake] Fix libomptarget/test/CMakeLists.txt (authored by azharudd). · Explain WhyJul 15 2018, 10:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

openmp/

trunk/

libomptarget/

test/

CMakeLists.txt

4 lines

Diff 155588

openmp/trunk/libomptarget/test/CMakeLists.txt

	# CMakeLists.txt file for unit testing OpenMP offloading runtime library.			# CMakeLists.txt file for unit testing OpenMP offloading runtime library.
	if(NOT "${OPENMP_TEST_COMPILER_ID}" STREQUAL "Clang" OR			if(NOT OPENMP_TEST_COMPILER_ID STREQUAL "Clang" OR
	${OPENMP_TEST_COMPILER_VERSION} VERSION_LESS 6.0.0)			OPENMP_TEST_COMPILER_VERSION VERSION_LESS 6.0.0)
	libomptarget_say("Can only test with Clang compiler in version 6.0.0 or later.")			libomptarget_say("Can only test with Clang compiler in version 6.0.0 or later.")
	libomptarget_warning_say("The check-libomptarget target will not be available!")			libomptarget_warning_say("The check-libomptarget target will not be available!")
	return()			return()
	endif()			endif()

	if(LIBOMPTARGET_CMAKE_BUILD_TYPE MATCHES debug)			if(LIBOMPTARGET_CMAKE_BUILD_TYPE MATCHES debug)
	set(LIBOMPTARGET_DEBUG True)			set(LIBOMPTARGET_DEBUG True)
	else()			else()
	Show All 17 Lines