Page MenuHomePhabricator

[modules] Print input files when -module-file-info file switch is passed.
ClosedPublic

Authored by v.g.vassilev on May 20 2018, 8:04 AM.

Diff Detail

Repository
rC Clang

Event Timeline

v.g.vassilev created this revision.May 20 2018, 8:04 AM

Thanks for improving this Vassil. Where does in the output it shows up? I wonder if we should have those at the end given the huge amount of headers some modules might have.

It looks like the diagnostic options and few others were moved out from the control block in r297655 by Manman Ren. The header files are still part of the control block. The best I can do is buffer that information and print it out last. Is that what we want?

bruno accepted this revision.Jun 28 2018, 9:46 AM

It looks like the diagnostic options and few others were moved out from the control block in r297655 by Manman Ren. The header files are still part of the control block. The best I can do is buffer that information and print it out last. Is that what we want?

Your patch as is seems fine. We can go for the buffering the output later on if it proves hard to read.

This revision is now accepted and ready to land.Jun 28 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.