This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Write out inconsistencies to a file.
ClosedPublic

Authored by courbet on May 17 2018, 5:42 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.May 17 2018, 5:42 AM
gchatelet requested changes to this revision.May 17 2018, 6:11 AM
gchatelet added inline comments.
tools/llvm-exegesis/llvm-exegesis.cpp
178 ↗(On Diff #147300)

Since there's no performance issue here, I'd rather separate the report generation from saving it:

std::string ClusterReport;
if (auto Err = Analyzer.printClusters(llvm::raw_string_ostream(ClusterReport))) {
  PrintAnalysis("analysis clusters", AnalysisClustersFile, ClusterReport );
}

std::string InconsistenciesReport;
if (auto Err = Analyzer.printClusters(llvm::raw_string_ostream(InconsistenciesReport))) {
  PrintAnalysis("sched class consistency analysis", AnalysisInconsistenciesFile, InconsistenciesReport );
}
This revision now requires changes to proceed.May 17 2018, 6:11 AM
courbet updated this revision to Diff 147306.May 17 2018, 6:28 AM
courbet marked an inline comment as done.

Slightly better approach for analysis pass selection.

courbet updated this revision to Diff 147307.May 17 2018, 6:30 AM

remove accidentally added file

courbet updated this revision to Diff 147308.May 17 2018, 6:35 AM

clang-format

courbet updated this revision to Diff 147309.May 17 2018, 6:36 AM

cosmetics

gchatelet accepted this revision.May 17 2018, 6:44 AM
This revision is now accepted and ready to land.May 17 2018, 6:44 AM
This revision was automatically updated to reflect the committed changes.