[llvm-exegesis] Write out inconsistencies to a file.

[gchatelet]

tools/llvm-exegesis/llvm-exegesis.cpp

178

Since there's no performance issue here, I'd rather separate the report generation from saving it:

std::string ClusterReport;
if (auto Err = Analyzer.printClusters(llvm::raw_string_ostream(ClusterReport))) {
  PrintAnalysis("analysis clusters", AnalysisClustersFile, ClusterReport );
}

std::string InconsistenciesReport;
if (auto Err = Analyzer.printClusters(llvm::raw_string_ostream(InconsistenciesReport))) {
  PrintAnalysis("sched class consistency analysis", AnalysisInconsistenciesFile, InconsistenciesReport );
}

[courbet]

Slightly better approach for analysis pass selection.

[courbet]

remove accidentally added file

[courbet]

clang-format

[courbet]

cosmetics

tools/llvm-exegesis/llvm-exegesis.cpp

 static llvm::cl::opt<float>
     AnalysisEpsilon("analysis-epsilon",
                     llvm::cl::desc("dbscan epsilon for analysis clustering"),
                     llvm::cl::init(0.1));
 
 static llvm::cl::opt<std::string> AnalysisClustersFile("analysis-clusters-file",
                                                        llvm::cl::desc(""),
                                                        llvm::cl::init("-"));
+static llvm::cl::opt<std::string>
+    AnalysisInconsistenciesFile("analysis-inconsistencies-file",
+                                llvm::cl::desc(""), llvm::cl::init("-"));
 
 namespace exegesis {
 
 static unsigned GetOpcodeOrDie(const llvm::MCInstrInfo &MCInstrInfo) {
   if (OpcodeName.empty() && (OpcodeIndex == 0))
     llvm::report_fatal_error(
         "please provide one and only one of 'opcode-index' or 'opcode-name'");
   if (OpcodeIndex > 0)
void benchmarkMain() {
   if (NumRepetitions == 0)
     llvm::report_fatal_error("--num-repetitions must be greater than zero");
 
   Runner->run(GetOpcodeOrDie(State.getInstrInfo()), Filter, NumRepetitions)
       .writeYamlOrDie(BenchmarkFile);
   exegesis::pfm::pfmTerminate();
 }
 
+// Prints the results of running analysis printer `Print` to file `Filename` if
+// Filename is non-empty.
+void maybePrintAnalysis(const Analysis &Analyzer, const std::string &Name,
+                        const std::string &Filename,
+                        llvm::Error (Analysis::*Print)(llvm::raw_ostream &)
+                            const) {
+  if (!Filename.empty()) {
+    if (Filename != "-") {
+      llvm::errs() << "Printing " << Name << " results to file '" << Filename
+                   << "'\n";
+    }
+    std::error_code ErrorCode;
+    llvm::raw_fd_ostream ClustersOS(Filename, ErrorCode, llvm::sys::fs::F_RW);
+    if (ErrorCode)
+      llvm::report_fatal_error("cannot open out file: " + Filename);
+    if (auto Err = (Analyzer.*Print)(ClustersOS))
+      llvm::report_fatal_error(std::move(Err));
+  }
+}
+
 void analysisMain() {
   // Read benchmarks.
   const std::vector<InstructionBenchmark> Points =
       InstructionBenchmark::readYamlsOrDie(BenchmarkFile);
   llvm::outs() << "Parsed " << Points.size() << " benchmark points\n";
   if (Points.empty()) {
     llvm::errs() << "no benchmarks to analyze\n";
     return;
if (!TheTarget) {
     llvm::errs() << "unknown target '" << Points[0].LLVMTriple << "'\n";
     return;
   }
   const auto Clustering = llvm::cantFail(InstructionBenchmarkClustering::create(
       Points, AnalysisNumPoints, AnalysisEpsilon));
 
   const Analysis Analyzer(*TheTarget, Clustering);
 
-  std::error_code ErrorCode;
-  llvm::raw_fd_ostream ClustersOS(AnalysisClustersFile, ErrorCode,
-                                  llvm::sys::fs::F_RW);
-  if (ErrorCode)
-    llvm::report_fatal_error("cannot open out file: " + AnalysisClustersFile);
-
-  if (auto Err = Analyzer.printClusters(ClustersOS))
-    llvm::report_fatal_error(std::move(Err));
-
-  if (auto Err = Analyzer.printSchedClassInconsistencies(llvm::outs()))
-    llvm::report_fatal_error(std::move(Err));
+  maybePrintAnalysis(Analyzer, "analysis clusters", AnalysisClustersFile,
+                     &Analysis::printClusters);
+  maybePrintAnalysis(Analyzer, "sched class consistency analysis",
+                     AnalysisInconsistenciesFile,
+                     &Analysis::printSchedClassInconsistencies);
 }
 
 } // namespace exegesis
 
 int main(int Argc, char **Argv) {
   llvm::cl::ParseCommandLineOptions(Argc, Argv, "");
 
   if (BenchmarkMode == BenchmarkModeE::Analysis) {
     exegesis::analysisMain();
   } else {
     exegesis::benchmarkMain();
   }
   return EXIT_SUCCESS;
 }