Page MenuHomePhabricator

[Debugfiy][WIP] Print the pass name next to the result

Authored by gramanas on May 15 2018, 3:27 PM.



CheckDebugify now prints the pass name right next to the result of the check.

Does not yet work with the new Pass Manager, hence the WIP.

Diff Detail


Event Timeline

gramanas created this revision.May 15 2018, 3:27 PM
gramanas edited the summary of this revision. (Show Details)May 15 2018, 3:36 PM

Thanks for the patch. Comments inline --

195 ↗(On Diff #146939)

You'll need to update test/DebugInfo/debugify-each.ll to reflect this change.

258 ↗(On Diff #146939)
67 ↗(On Diff #146939)

There isn't support for -debugify-each in the newPM yet, so there's no need to tackle that in this patch. I think we should leave newPM-related changes to a future patch.

67 ↗(On Diff #146939)

I think 'NameOfWrappedPass' would be a more accurate/descriptive name here.

gramanas updated this revision to Diff 146955.May 15 2018, 4:13 PM
  • Adress review comments
vsk accepted this revision.May 15 2018, 4:16 PM

LGTM. Thanks!

As a follow-up, would you mind fixing the situation with debugify output? Currently we're dumping a lot of information to stdout. Ideally we would only print the result of the pipeline to stdout, so as to not break piping opt's output to other LLVM tools. As a first step, I think all of debugify's warnings and messages should be sent to stderr, and then eventually to a separate file.

This revision is now accepted and ready to land.May 15 2018, 4:16 PM
gramanas marked 4 inline comments as done.May 15 2018, 4:28 PM

Will do, it's allready in my TODO list!

This revision was automatically updated to reflect the committed changes.