User Details
- User Since
- Mar 9 2018, 4:28 AM (225 w, 4 d)
Aug 7 2018
- update according to comments
Add unit test.
Aug 6 2018
Aug 3 2018
- typo
Jul 31 2018
Did you try "ninja check-all"? Everything ok?
Jul 30 2018
Jul 27 2018
This results in many ICmp Instructions to have completely wrong !dbg attached, since it points to a different subprogram.
ping!
Jul 25 2018
- update to reflect the comments
Jul 24 2018
Jul 23 2018
- Update test according to comments.
Jul 19 2018
Can there be multiple induction phis in the original loop's header? If so, why is picking the location from the first phi correct?
Adressing latest comments
Jul 17 2018
- DebugLoc pass by value
- embed code in helper function
Jul 16 2018
- styling nit
- Refactored the createInductionVariable() function to accept DebugLoc instead of Instruction.
- Get the debugLoc to set from the oldBasicBlock's induction variable if any.`
Jul 15 2018
Jul 13 2018
- minor styling changes
- change section title to reflect contents
- add note for robust tests
Jul 11 2018
- Address inline comments.
Jul 10 2018
Address inline comments.
Jul 9 2018
Use exact line in test
- Code blocks had some whitespace
- Check that arc works with new dev envrionment
Jul 7 2018
Jul 6 2018
Make test more readable
Jul 5 2018
typo in test
Jul 4 2018
Jun 30 2018
Addressing inline comments.
Formatting
If there isn't a simpler file to repurpose as a debug info test, it would be simpler to create a (perhaps more reduced?) test.
Address inline comments.
Jun 29 2018
Jun 28 2018
Incorporate the -debugify test into the existing test files.
Remove -instcombine from the RUN clause of the test.
Jun 27 2018
Addressing the comments
- Update the scalar case according to the comments
- Postpone vector case for a later patch
Jun 26 2018
Jun 25 2018
- Focus on the scalar test case
- Use fragments since the width of the Src and Res instructions change
Jun 21 2018
Fragments don't seem to be needed here
Jun 20 2018
Update lamda to return nullptr if it fails to create the fragment.
Make use of rL335144 utility.
Clean up code and test
Jun 19 2018
Add RUN: clause to the test
ping! should I commit this?
Jun 7 2018
Make more elaborate comment.
Jun 6 2018
make code more readable
What about this? Ping!
Jun 5 2018
Add artificial debug location to the phi instruction
Add comment explaining the test