Page MenuHomePhabricator

gramanas (Anastasis)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2018, 4:28 AM (75 w, 1 d)

Recent Activity

Aug 7 2018

gramanas committed rL339173: [Local] Add dbg location on unreachable inst in changeToUnreachable.
[Local] Add dbg location on unreachable inst in changeToUnreachable
Aug 7 2018, 1:22 PM
gramanas closed D50340: [Local] Add dbg location on unreachable inst in changeToUnreachable.
Aug 7 2018, 1:22 PM
gramanas updated the diff for D50340: [Local] Add dbg location on unreachable inst in changeToUnreachable.
  • update according to comments
Aug 7 2018, 12:29 PM
gramanas updated the diff for D50340: [Local] Add dbg location on unreachable inst in changeToUnreachable.

Add unit test.

Aug 7 2018, 11:53 AM

Aug 6 2018

gramanas created D50340: [Local] Add dbg location on unreachable inst in changeToUnreachable.
Aug 6 2018, 10:25 AM

Aug 3 2018

gramanas committed rL338917: [TRE][DebugInfo] Preserve Debug Location in new branch instruction.
[TRE][DebugInfo] Preserve Debug Location in new branch instruction
Aug 3 2018, 1:27 PM
gramanas closed D50263: [TRE][DebugInfo] Preserve Debug Location in new branch instruction.
Aug 3 2018, 1:27 PM
gramanas updated the diff for D50263: [TRE][DebugInfo] Preserve Debug Location in new branch instruction.
  • typo
Aug 3 2018, 10:19 AM
gramanas created D50263: [TRE][DebugInfo] Preserve Debug Location in new branch instruction.
Aug 3 2018, 10:18 AM

Jul 31 2018

gramanas added a comment to D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.

Did you try "ninja check-all"? Everything ok?

Jul 31 2018, 8:21 AM
gramanas committed rL338391: [DebugInfo][LCSSA] Preserve debug location in lcssa phis.
[DebugInfo][LCSSA] Preserve debug location in lcssa phis
Jul 31 2018, 7:55 AM
gramanas closed D50009: [DebugInfo][LCSSA] Preserve debug location in lcssa phis.
Jul 31 2018, 7:55 AM

Jul 30 2018

gramanas created D50009: [DebugInfo][LCSSA] Preserve debug location in lcssa phis.
Jul 30 2018, 1:30 PM

Jul 27 2018

gramanas added a comment to D49746: [WIP][LV][DebugInfo] Set DL to the middle block Icmp instruction.

This results in many ICmp Instructions to have completely wrong !dbg attached, since it points to a different subprogram.

Jul 27 2018, 1:40 AM
gramanas committed rL338109: Revert "[LV][DebugInfo] Set DL to the middle block Icmp instruction".
Revert "[LV][DebugInfo] Set DL to the middle block Icmp instruction"
Jul 27 2018, 1:23 AM
gramanas added a comment to D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.

ping!

Jul 27 2018, 12:19 AM
gramanas committed rL338106: [LV][DebugInfo] Set DL to the middle block Icmp instruction.
[LV][DebugInfo] Set DL to the middle block Icmp instruction
Jul 27 2018, 12:13 AM
gramanas closed D49746: [WIP][LV][DebugInfo] Set DL to the middle block Icmp instruction.
Jul 27 2018, 12:13 AM

Jul 25 2018

gramanas updated the diff for D49746: [WIP][LV][DebugInfo] Set DL to the middle block Icmp instruction.
  • update to reflect the comments
Jul 25 2018, 6:45 AM
gramanas added a comment to D49746: [WIP][LV][DebugInfo] Set DL to the middle block Icmp instruction.

This is essentially a zero trip check for the remainder loop and from that perspective, the most correct DL we should use would be the one related to trip count computation. InnerLoopVectorizer::getOrCreateTripCount() is where LV computes the trip count of the incoming scalar loop. It uses getBackedgeTakeCount(). As such, strictly speaking, taking the DL from the predicate (i.e., loop bottom test) fed to the loop backedge would make most sense. That would be OrigLoop->getLoopLatch()->getTerminator() to get to the backedge. In a relaxed thinking, however, this is the code executed when we know vector code executes. So, taking DL from VectorPH code isn't too bad. OrigLoop->getStartLoc() could be another viable enough alternative.

Does this make sense to you? Which one would you pick?

Jul 25 2018, 6:40 AM

Jul 24 2018

gramanas created D49746: [WIP][LV][DebugInfo] Set DL to the middle block Icmp instruction.
Jul 24 2018, 11:28 AM

Jul 23 2018

gramanas updated the diff for D49677: [WIP][IC][DebugInfo] Preserve DI value when folding cast into phi.
  • Update test according to comments.
Jul 23 2018, 11:32 AM
gramanas created D49677: [WIP][IC][DebugInfo] Preserve DI value when folding cast into phi.
Jul 23 2018, 10:11 AM

Jul 19 2018

gramanas added a comment to D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.

Can there be multiple induction phis in the original loop's header? If so, why is picking the location from the first phi correct?

Jul 19 2018, 11:31 AM
gramanas committed rL337457: [Docs] Testing Debug Info Preservation in Optimizations.
[Docs] Testing Debug Info Preservation in Optimizations
Jul 19 2018, 7:14 AM
gramanas closed D49053: [Docs] Testing Debug Info Preservation in Optimizations.
Jul 19 2018, 7:14 AM
gramanas updated the diff for D49053: [Docs] Testing Debug Info Preservation in Optimizations.

Adressing latest comments

Jul 19 2018, 7:08 AM

Jul 17 2018

gramanas retitled D49053: [Docs] Testing Debug Info Preservation in Optimizations from [Docs] Debugging optimized code with debugify to [Docs] Testing Debug Info Preservation in Optimizations.
Jul 17 2018, 9:21 AM
gramanas updated the diff for D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.
  • DebugLoc pass by value
  • embed code in helper function
Jul 17 2018, 9:11 AM
gramanas added inline comments to D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.
Jul 17 2018, 7:28 AM
gramanas added reviewers for D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI: mkuper, hsaito.
Jul 17 2018, 6:57 AM
gramanas retitled D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI from [WIP][DebugInfo][InstCombine] DebugLoc in induction PHI to [WIP][DebugInfo][LV] DebugLoc in induction PHI.
Jul 17 2018, 6:51 AM

Jul 16 2018

gramanas updated the diff for D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.
  • styling nit
Jul 16 2018, 9:40 AM
gramanas updated the diff for D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.
  • Refactored the createInductionVariable() function to accept DebugLoc instead of Instruction.
  • Get the debugLoc to set from the oldBasicBlock's induction variable if any.`
Jul 16 2018, 9:38 AM

Jul 15 2018

gramanas added inline comments to D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.
Jul 15 2018, 6:12 AM
gramanas created D49347: [WIP][DebugInfo][LV] DebugLoc in induction PHI.
Jul 15 2018, 6:06 AM

Jul 13 2018

gramanas retitled D49053: [Docs] Testing Debug Info Preservation in Optimizations from [WIP][Docs] Debugging optimized code with debugify to [Docs] Debugging optimized code with debugify.
Jul 13 2018, 8:41 AM
gramanas updated the diff for D49053: [Docs] Testing Debug Info Preservation in Optimizations.
  • minor styling changes
Jul 13 2018, 8:40 AM
gramanas updated the diff for D49053: [Docs] Testing Debug Info Preservation in Optimizations.
  • change section title to reflect contents
  • add note for robust tests
Jul 13 2018, 8:28 AM

Jul 11 2018

gramanas updated the diff for D49053: [Docs] Testing Debug Info Preservation in Optimizations.
  • Address inline comments.
Jul 11 2018, 8:51 AM

Jul 10 2018

gramanas added a comment to D49053: [Docs] Testing Debug Info Preservation in Optimizations.
Jul 10 2018, 11:27 AM
gramanas updated the diff for D49053: [Docs] Testing Debug Info Preservation in Optimizations.

Address inline comments.

Jul 10 2018, 11:27 AM
gramanas committed rL336667: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.
[DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add
Jul 10 2018, 6:34 AM
gramanas closed D48968: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.
Jul 10 2018, 6:34 AM

Jul 9 2018

gramanas updated the diff for D48968: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.

Use exact line in test

Jul 9 2018, 6:37 AM
gramanas updated the diff for D49053: [Docs] Testing Debug Info Preservation in Optimizations.
  • Code blocks had some whitespace
  • Check that arc works with new dev envrionment
Jul 9 2018, 5:42 AM

Jul 7 2018

gramanas created D49053: [Docs] Testing Debug Info Preservation in Optimizations.
Jul 7 2018, 10:36 AM

Jul 6 2018

gramanas added inline comments to D48968: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.
Jul 6 2018, 6:48 AM
gramanas updated the diff for D48968: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.

Make test more readable

Jul 6 2018, 6:48 AM

Jul 5 2018

gramanas updated the diff for D48968: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.

typo in test

Jul 5 2018, 6:45 AM
gramanas created D48968: [DebugInfo][LoopVectorize] Preserve DL in induction PHI and Add.
Jul 5 2018, 6:42 AM

Jul 4 2018

gramanas added inline comments to D48676: [Local] replaceAllDbgUsesWith: Update debug values before RAUW.
Jul 4 2018, 5:55 AM
gramanas committed rL336256: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.
[DebugInfo][LoopVectorize] Preserve DL in generated phi instruction
Jul 4 2018, 3:21 AM
gramanas closed D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.
Jul 4 2018, 3:21 AM
gramanas committed rL336254: [DebugInfo][InstCombine] Preserve DI after combining zext.
[DebugInfo][InstCombine] Preserve DI after combining zext
Jul 4 2018, 3:00 AM
gramanas closed D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jul 4 2018, 3:00 AM

Jun 30 2018

gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Addressing inline comments.

Jun 30 2018, 5:45 AM
gramanas updated the diff for D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.

Formatting

Jun 30 2018, 5:26 AM
gramanas added a comment to D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.

If there isn't a simpler file to repurpose as a debug info test, it would be simpler to create a (perhaps more reduced?) test.

Jun 30 2018, 5:24 AM
gramanas updated the diff for D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.

Address inline comments.

Jun 30 2018, 5:10 AM

Jun 29 2018

gramanas updated the summary of D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.
Jun 29 2018, 5:39 AM
gramanas created D48769: [DebugInfo][LoopVectorize] Preserve DL in generated phi instruction.
Jun 29 2018, 5:38 AM

Jun 28 2018

gramanas committed rL335904: [SROA] Preserve DebugLoc when rewriting alloca partitions.
[SROA] Preserve DebugLoc when rewriting alloca partitions
Jun 28 2018, 12:03 PM
gramanas closed D48640: [SROA] Preserve DebugLoc when rewriting alloca partitions.
Jun 28 2018, 12:03 PM
gramanas retitled D48640: [SROA] Preserve DebugLoc when rewriting alloca partitions from [WIP][SROA] Preserve DebugLoc when rewriting alloca partitions to [SROA] Preserve DebugLoc when rewriting alloca partitions.
Jun 28 2018, 7:10 AM
gramanas added inline comments to D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 28 2018, 6:05 AM
gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Incorporate the -debugify test into the existing test files.

Jun 28 2018, 6:03 AM
gramanas added inline comments to D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 28 2018, 5:00 AM
gramanas added inline comments to D48640: [SROA] Preserve DebugLoc when rewriting alloca partitions.
Jun 28 2018, 4:07 AM
gramanas updated the diff for D48640: [SROA] Preserve DebugLoc when rewriting alloca partitions.

Remove -instcombine from the RUN clause of the test.

Jun 28 2018, 4:04 AM

Jun 27 2018

gramanas updated the diff for D48640: [SROA] Preserve DebugLoc when rewriting alloca partitions.

Addressing the comments

Jun 27 2018, 10:17 AM
gramanas created D48640: [SROA] Preserve DebugLoc when rewriting alloca partitions.
Jun 27 2018, 5:42 AM
gramanas retitled D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions from [[DebugInfo][InstCombine] Preserve DI after combining zext instructions to [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 27 2018, 4:34 AM
gramanas retitled D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions from [WIP][DebugInfo][InstCombine] Preserve DI after merging zext instructions to [[DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 27 2018, 4:34 AM
gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
  • Update the scalar case according to the comments
  • Postpone vector case for a later patch
Jun 27 2018, 4:11 AM

Jun 26 2018

gramanas added inline comments to D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 26 2018, 1:40 PM
gramanas added inline comments to D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 26 2018, 12:33 PM
gramanas added inline comments to D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 26 2018, 6:08 AM

Jun 25 2018

gramanas updated the summary of D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 25 2018, 7:35 AM
gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
  • Focus on the scalar test case
  • Use fragments since the width of the Src and Res instructions change
Jun 25 2018, 7:33 AM

Jun 21 2018

gramanas committed rC335255: [DebugInfo] Inline for without DebugLocation.
[DebugInfo] Inline for without DebugLocation
Jun 21 2018, 9:58 AM
gramanas committed rL335255: [DebugInfo] Inline for without DebugLocation.
[DebugInfo] Inline for without DebugLocation
Jun 21 2018, 9:58 AM
gramanas closed D47720: [DebugInfo] Inline for without DebugLocation.
Jun 21 2018, 9:58 AM
gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Fragments don't seem to be needed here

Jun 21 2018, 3:06 AM

Jun 20 2018

gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Update lamda to return nullptr if it fails to create the fragment.

Jun 20 2018, 2:29 PM
gramanas retitled D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions from [DebugInfo][InstCombine] Preserve DI after merging instructions to [WIP][DebugInfo][InstCombine] Preserve DI after merging zext instructions.
Jun 20 2018, 2:11 PM
gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Make use of rL335144 utility.

Jun 20 2018, 1:59 PM
gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Clean up code and test

Jun 20 2018, 2:27 AM

Jun 19 2018

gramanas updated the diff for D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.

Add RUN: clause to the test

Jun 19 2018, 12:20 PM
gramanas added inline comments to D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 19 2018, 12:08 PM
gramanas updated the summary of D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 19 2018, 12:07 PM
gramanas created D48331: [DebugInfo][InstCombine] Preserve DI after combining zext instructions.
Jun 19 2018, 12:06 PM
gramanas added a comment to D47720: [DebugInfo] Inline for without DebugLocation.

ping! should I commit this?

Jun 19 2018, 7:35 AM

Jun 7 2018

gramanas updated the diff for D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

Make more elaborate comment.

Jun 7 2018, 10:12 AM

Jun 6 2018

gramanas updated the diff for D47720: [DebugInfo] Inline for without DebugLocation.

make code more readable

Jun 6 2018, 7:51 AM
gramanas added a comment to D47097: [DebugInfo] Preserve scope in auto generated StoreInst.

What about this? Ping!

Jun 6 2018, 6:49 AM

Jun 5 2018

gramanas added inline comments to D47720: [DebugInfo] Inline for without DebugLocation.
Jun 5 2018, 1:48 PM
gramanas updated the diff for D47720: [DebugInfo] Inline for without DebugLocation.

Add artificial debug location to the phi instruction

Jun 5 2018, 1:47 PM
gramanas updated the diff for D47720: [DebugInfo] Inline for without DebugLocation.

Add comment explaining the test

Jun 5 2018, 9:00 AM

Jun 4 2018

gramanas created D47720: [DebugInfo] Inline for without DebugLocation.
Jun 4 2018, 8:08 AM