This is an archive of the discontinued LLVM Phabricator instance.

add AR to acronyms of clang-tidy property check
ClosedPublic

Authored by Wizard on May 15 2018, 10:27 AM.

Diff Detail

Event Timeline

Wizard created this revision.May 15 2018, 10:27 AM
benhamilton accepted this revision.May 15 2018, 10:36 AM
This revision is now accepted and ready to land.May 15 2018, 10:36 AM
This revision was automatically updated to reflect the committed changes.
stephanemoore added inline comments.
clang-tidy/objc/PropertyDeclarationCheck.cpp
37–38

This comment does not seem to be accurate anymore. The acronyms in this list are not all from the linked Apple documentation.

Sent out https://reviews.llvm.org/D46922.

45

Are we sure it's sustainable to keep growing this list of acronyms? I suspect there may be enough domain-specific acronyms that it might be better to accept any sequence of capitalized alphanumeric characters as an acronym.