This is an archive of the discontinued LLVM Phabricator instance.

[checks/property-decls] Fix comment in clang-tidy/objc/PropertyDeclarationCheck.cpp ✍️
ClosedPublic

Authored by stephanemoore on May 15 2018, 6:42 PM.

Reviewers

Wizard
benhamilton

Commits

Summary

The comment incorrectly claims that the listed acronyms are all extracted from the linked Apple documentation.

This revision is now accepted and ready to land.May 25 2018, 5:12 PM

Is it possible to get someone to land this for me? I don't believe I have access to land it myself.

Is it possible to get someone to land this for me? I don't believe I have access to land it myself.

Done.

This revision was automatically updated to reflect the committed changes.

In D46922#1125689, @benhamilton wrote:

Is it possible to get someone to land this for me? I don't believe I have access to land it myself.

Done.

Thank you, kind sir 🙇

Path

Size

clang-tools-extra/

trunk/

clang-tidy/

objc/

2 lines

	Show All 28 Lines
	// For CategoryProperty especially in categories of system class,			// For CategoryProperty especially in categories of system class,
	// to avoid naming conflict, the suggested naming style is			// to avoid naming conflict, the suggested naming style is
	// 'abc_lowerCamelCase' (adding lowercase prefix followed by '_').			// 'abc_lowerCamelCase' (adding lowercase prefix followed by '_').
	enum NamingStyle {			enum NamingStyle {
	StandardProperty = 1,			StandardProperty = 1,
	CategoryProperty = 2,			CategoryProperty = 2,
	};			};

	/// The acronyms are from			/// The acronyms are aggregated from multiple sources including
	/// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20001285-BCIHCGAE			/// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20001285-BCIHCGAE
	///			///
	/// Keep this list sorted.			/// Keep this list sorted.
	constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {			constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {
	"[2-9]G",			"[2-9]G",
	"ACL",			"ACL",
	"API",			"API",
	"AR",			"AR",
	▲ Show 20 Lines • Show All 210 Lines • Show Last 20 Lines