This is an archive of the discontinued LLVM Phabricator instance.

[DWARF] Have HashedNameToDIE store a DataExtractor by value
ClosedPublic

Authored by labath on May 15 2018, 9:19 AM.

Details

Summary

The DataExtractors are cheap to copy so there is no reason to store them
by reference. Also, in my upcoming indexing refactor I am planning to
remove the apple tables data extractor members from the SymbolFileDWARF
class, so there will not be a DataExtractor with a suitable lifetime to
refer to.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.May 15 2018, 9:19 AM
This revision is now accepted and ready to land.May 16 2018, 2:23 AM
clayborg accepted this revision.May 16 2018, 10:56 AM
This revision was automatically updated to reflect the committed changes.