This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Add an analysis mode.
ClosedPublic

Authored by courbet on May 15 2018, 1:58 AM.

Details

Summary

The analysis mode gives the user a clustered view of the measurement results.
Next steps are (requires the split ok AsmTemplate.Name into {mnemonic, mode}):

  • Show the sched class.
  • Highlight any inconsistencies with the checked-in data.

Diff Detail

Event Timeline

courbet created this revision.May 15 2018, 1:58 AM
courbet updated this revision to Diff 146759.May 15 2018, 1:59 AM
  • add missing file header.
courbet updated this revision to Diff 146761.May 15 2018, 2:02 AM

cosmetics + clang-format

gchatelet requested changes to this revision.May 15 2018, 2:15 AM
gchatelet added inline comments.
tools/llvm-exegesis/lib/Analysis.cpp
20

Technically CSV is comma separated and not semicolon separated.
Semicolon seems to be a popular variant in French but not necessarily in other locales.
Also strings should be quoted to prevent interpretation of comma (semicolon) within them.

tools/llvm-exegesis/lib/Clustering.cpp
22

?

This revision now requires changes to proceed.May 15 2018, 2:15 AM
courbet updated this revision to Diff 146772.May 15 2018, 3:18 AM
courbet marked an inline comment as done.

Escape csv strings if needed.

courbet added inline comments.May 15 2018, 3:19 AM
tools/llvm-exegesis/lib/Clustering.cpp
22

Bad merge. Fixed.

courbet marked an inline comment as done.May 15 2018, 3:20 AM
courbet marked an inline comment as done.May 15 2018, 4:43 AM
gchatelet accepted this revision.May 15 2018, 4:48 AM
This revision is now accepted and ready to land.May 15 2018, 4:48 AM
This revision was automatically updated to reflect the committed changes.