This is an archive of the discontinued LLVM Phabricator instance.

[MemorySSA] getIncomingValueForBlock should return a MemoryAccess.
ClosedPublic

Authored by asbirlea on May 11 2018, 3:08 PM.

Reviewers

george.burgess.iv

Commits

Summary

getIncomingValueForBlock is just a wrapper API that should return a MemoryAccess, instead of a generic Value.

Repository

rL LLVM

Build Status

Buildable 18013
Build 18013: arc lint + arc unit

Thanks!

This revision is now accepted and ready to land.May 11 2018, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

include/

llvm/

Analysis/

2 lines

Show First 20 Lines • Show All 551 Lines • ▼ Show 20 Lines	public:
/// block in the value list for this PHI. Returns -1 if no instance.		/// block in the value list for this PHI. Returns -1 if no instance.
int getBasicBlockIndex(const BasicBlock *BB) const {		int getBasicBlockIndex(const BasicBlock *BB) const {
for (unsigned I = 0, E = getNumOperands(); I != E; ++I)		for (unsigned I = 0, E = getNumOperands(); I != E; ++I)
if (block_begin()[I] == BB)		if (block_begin()[I] == BB)
return I;		return I;
return -1;		return -1;
}		}

Value getIncomingValueForBlock(const BasicBlock BB) const {		MemoryAccess getIncomingValueForBlock(const BasicBlock BB) const {
int Idx = getBasicBlockIndex(BB);		int Idx = getBasicBlockIndex(BB);
assert(Idx >= 0 && "Invalid basic block argument!");		assert(Idx >= 0 && "Invalid basic block argument!");
return getIncomingValue(Idx);		return getIncomingValue(Idx);
}		}

static bool classof(const Value *V) {		static bool classof(const Value *V) {
return V->getValueID() == MemoryPhiVal;		return V->getValueID() == MemoryPhiVal;
}		}
▲ Show 20 Lines • Show All 662 Lines • Show Last 20 Lines