Splitting thinlto.ll test file and renaming other test files.
Details
Details
Diff Detail
Diff Detail
- Repository
- rLLD LLVM Linker
Event Timeline
Comment Actions
Looks great. Thank you for doing this.
lld/test/ELF/lto/thinlto-index-file.ll | ||
---|---|---|
8–13 ↗ | (On Diff #146245) | Could you factor this test to a separate file? |
lld/test/ELF/lto/thinlto-index-file.ll | ||
---|---|---|
10 ↗ | (On Diff #146251) | Now that you have only one FileCheck, you can remove --check-prefix and replace IN1 with CHECK. FileCheck %s < %tlinkobjfile is more straightforward than cat. Please don't use a long file name because this file is short enough. %tlinkedobfile ->%t.idx |
lld/test/ELF/lto/thinlto-no-index.ll | ||
4 ↗ | (On Diff #146251) | %t.o, %t2.o and %t4.o look a bit odd. Please rename them %t1.o, %t2.o and %t3.o. |
lld/test/ELF/lto/thinlto-obj-path.ll | ||
9 ↗ | (On Diff #146251) | Remove -check-prefix. |
Comment Actions
LGTM
lld/test/ELF/lto/thinlto-no-index.ll | ||
---|---|---|
9–11 ↗ | (On Diff #146354) | rm -f %t1.o.thinlto.bc %t2.o.thinlto.bc %t3.o.thinlto.bc |