This is an archive of the discontinued LLVM Phabricator instance.

Splitting thinlto.ll test file and renaming other test files.
ClosedPublic

Authored by rdhindsa on May 10 2018, 3:44 PM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

rdhindsa created this revision.May 10 2018, 3:44 PM
ruiu added a comment.May 10 2018, 3:50 PM

Looks great. Thank you for doing this.

lld/test/ELF/lto/thinlto-index-file.ll
9–14

Could you factor this test to a separate file?

rdhindsa updated this revision to Diff 146251.May 10 2018, 4:07 PM
rdhindsa marked an inline comment as done.
ruiu added inline comments.May 10 2018, 4:11 PM
lld/test/ELF/lto/thinlto-index-file.ll
10

Now that you have only one FileCheck, you can remove --check-prefix and replace IN1 with CHECK.

FileCheck %s < %tlinkobjfile

is more straightforward than cat.

Please don't use a long file name because this file is short enough. %tlinkedobfile ->%t.idx

lld/test/ELF/lto/thinlto-no-index.ll
4

%t.o, %t2.o and %t4.o look a bit odd. Please rename them %t1.o, %t2.o and %t3.o.

lld/test/ELF/lto/thinlto-obj-path.ll
9

Remove -check-prefix.

rdhindsa updated this revision to Diff 146354.May 11 2018, 10:32 AM
rdhindsa marked 3 inline comments as done.
ruiu accepted this revision.May 11 2018, 11:06 AM

LGTM

lld/test/ELF/lto/thinlto-no-index.ll
10–12

rm -f %t1.o.thinlto.bc %t2.o.thinlto.bc %t3.o.thinlto.bc

This revision is now accepted and ready to land.May 11 2018, 11:06 AM
This revision was automatically updated to reflect the committed changes.