This is an archive of the discontinued LLVM Phabricator instance.

Differential D46639

[CodeComplete] Provide completion in decls even for incomplete types
ClosedPublic

Authored by ilya-biryukov on May 9 2018, 7:53 AM.

Details

Reviewers
bkramer
aaron.ballman
sammccall
Commits
rGfb9dde704098: [CodeComplete] Provide completion in decls even for incomplete types
rC332244: [CodeComplete] Provide completion in decls even for incomplete types
rL332244: [CodeComplete] Provide completion in decls even for incomplete types
Summary

This change fixes lack of completions in the following case
('^'designates completion points) :

void f(^);
struct Incomplete;
Incomplete g(^);

Diff Detail

Repository
rL LLVM

Event Timeline

ilya-biryukov created this revision.May 9 2018, 7:53 AM
Harbormaster completed remote builds in B17888: Diff 145922.May 9 2018, 7:53 AM
aaron.ballman accepted this revision.May 13 2018, 2:22 PM

LGTM!

This revision is now accepted and ready to land.May 13 2018, 2:22 PM
Closed by commit rL332244: [CodeComplete] Provide completion in decls even for incomplete types (authored by ibiryukov). · Explain WhyMay 14 2018, 6:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptMay 14 2018, 6:54 AM

Revision Contents

PathSize
cfe/
trunk/
lib/
Sema/
6 lines
test/
CodeCompletion/
13 lines

Diff 146595

cfe/trunk/lib/Sema/SemaCodeComplete.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,487 Lines • ▼ Show 20 Lines
} }
void Sema::CodeCompleteConstructor(Scope *S, QualType Type, SourceLocation Loc, void Sema::CodeCompleteConstructor(Scope *S, QualType Type, SourceLocation Loc,
ArrayRef<Expr *> Args) { ArrayRef<Expr *> Args) {
if (!CodeCompleter) if (!CodeCompleter)
return; return;
// A complete type is needed to lookup for constructors. // A complete type is needed to lookup for constructors.
if (!isCompleteType(Loc, Type)) CXXRecordDecl *RD =
return; isCompleteType(Loc, Type) ? Type->getAsCXXRecordDecl() : nullptr;
CXXRecordDecl *RD = Type->getAsCXXRecordDecl();
if (!RD) { if (!RD) {
CodeCompleteExpression(S, Type); CodeCompleteExpression(S, Type);
return; return;
} }
// FIXME: Provide support for member initializers. // FIXME: Provide support for member initializers.
// FIXME: Provide support for variadic template constructors. // FIXME: Provide support for variadic template constructors.
▲ Show 20 Lines • Show All 3,480 Lines • Show Last 20 Lines

cfe/trunk/test/CodeCompletion/incomplete-ret-type.cpp

struct IncompleteType;
int int_value;
typedef int int_typedef;
void f(in);
IncompleteType g(in);
// Completing should produce results even if types are incomplete.
// Note that clang is expected to return an error code since 'in' does not resolve.
// RUN: not %clang_cc1 -fsyntax-only -code-completion-at=%s:5:9 %s -o - | FileCheck %s
// RUN: not %clang_cc1 -fsyntax-only -code-completion-at=%s:6:19 %s -o - | FileCheck %s
// CHECK: COMPLETION: int{{$}}
// CHECK: COMPLETION: int_typedef
// CHECK: COMPLETION: int_value