This is an archive of the discontinued LLVM Phabricator instance.

Differential D46571

[asan] Fix bug introduced by r331647
ClosedPublic

Authored by waltl on May 7 2018, 10:55 PM.

Details

Reviewers
vitalybuka
eugenis
alekseyshl
Summary

unmap_shadow_on_exit was inadvertently flipped for non-RTEMS.

Diff Detail

Event Timeline

waltl created this revision.May 7 2018, 10:55 PM
Herald added a subscriber: kubamracek. · View Herald TranscriptMay 7 2018, 10:55 PM
Harbormaster completed remote builds in B17825: Diff 145631.May 7 2018, 10:55 PM
vitalybuka accepted this revision.May 7 2018, 11:00 PM
This revision is now accepted and ready to land.May 7 2018, 11:00 PM
waltl closed this revision.May 8 2018, 10:32 AM

Commited as r331737.

Revision Contents

PathSize
compiler-rt/
lib/
asan/
2 lines

Diff 145631

compiler-rt/lib/asan/asan_flags.inc

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 LinesASAN_FLAG(
"needs to attach gdb).") "needs to attach gdb).")
ASAN_FLAG( ASAN_FLAG(
int, sleep_after_init, 0, int, sleep_after_init, 0,
"Number of seconds to sleep after AddressSanitizer is initialized. " "Number of seconds to sleep after AddressSanitizer is initialized. "
"Useful for debugging purposes (e.g. when one needs to attach gdb).") "Useful for debugging purposes (e.g. when one needs to attach gdb).")
ASAN_FLAG(bool, check_malloc_usable_size, true, ASAN_FLAG(bool, check_malloc_usable_size, true,
"Allows the users to work around the bug in Nvidia drivers prior to " "Allows the users to work around the bug in Nvidia drivers prior to "
"295.*.") "295.*.")
ASAN_FLAG(bool, unmap_shadow_on_exit, !SANITIZER_RTEMS, ASAN_FLAG(bool, unmap_shadow_on_exit, false,
"If set, explicitly unmaps the (huge) shadow at exit.") "If set, explicitly unmaps the (huge) shadow at exit.")
ASAN_FLAG(bool, protect_shadow_gap, !SANITIZER_RTEMS, ASAN_FLAG(bool, protect_shadow_gap, !SANITIZER_RTEMS,
"If set, mprotect the shadow gap") "If set, mprotect the shadow gap")
ASAN_FLAG(bool, print_stats, false, ASAN_FLAG(bool, print_stats, false,
"Print various statistics after printing an error message or if " "Print various statistics after printing an error message or if "
"atexit=1.") "atexit=1.")
ASAN_FLAG(bool, print_legend, true, "Print the legend for the shadow bytes.") ASAN_FLAG(bool, print_legend, true, "Print the legend for the shadow bytes.")
ASAN_FLAG(bool, print_scariness, false, ASAN_FLAG(bool, print_scariness, false,
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines