[lit, lldbsuite] Fixes for several tests LLDB tests for Python 3 or Windows

[stella.stamenova]

Summary

In decorators.py, when opening streams, open them in text mode. In Py3, if they are not opened in text mode, the data is also expected to be binary, but we always use text data.
In TestLinuxCore, skip the tests that are not applicable on Windows
In the python api main.c, update the code to be compilable on Windows

[zturner]

packages/Python/lldbsuite/test/python_api/hello_world/main.c

20 ↗

(On Diff #145219)

On posix this is a number of seconds, but on Windows this is a number of milliseconds. So perhaps your macro above should be #define sleep(x) Sleep((x) * 1000). Thoughts?

[stella.stamenova]

packages/Python/lldbsuite/test/python_api/hello_world/main.c

20 ↗

(On Diff #145219)

Good catch! The test is happily passing either way in our setup, but it will be better to update it. I'll make the change.

[stella.stamenova]

I don't have commit permissions. @zturner or @asmith, could you please commit this? Thanks!

[zturner]

In D46440#1088623, @stella.stamenova wrote:

I don't have commit permissions. @zturner or @asmith, could you please commit this? Thanks!

This would probably be as good a time as any for you to get them. I think you've made a number of useful contributions and probably passed the bar for getting commit access :)

[asmith]

Will commit it Sunday if Zachary doesn’t do it before then.

[stella.stamenova]

Update the diff to contain all the changes (the last diff only had the hello world file).

[labath]

lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py

41–69

I don't think it's fair to say that these "are not applicable to windows". These test debugging of (linux) core files, which should work same way on any platform (it already works on darwin, for example). So, it looks like there is something in the windows host layer preventing these from working. I'm not saying it has to be done now, but I think getting to the bottom of this would be very useful. Besides being able to run cross-platform tests, you'll probably also discover some genuine bugs that need fixing.

[stella.stamenova]

lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py

41–69

I followed the pattern in the rest of the file (there are 3 more tests in this file all of which are disabled on Windows) - and it looked that all of the tests should either be enabled on Windows or not. If you think that they need to be enabled, I can file a bug and then add a reference in the file, so that they can all be fixed. Let me know.

[labath]

Yes, the other tests are marked as skipped for the same reason as you have
skipped these: "for some reason, they don't work on windows". However, this
is definitely a bug. You should be able to inspect a linux core file on
windows (we have tests opening windows minidumps on linux, and they are
working fine).

lldb/trunk/packages/Python/lldbsuite/test/decorators.py

return skipTestIfFn(
             archs))
 
 def skipUnlessSupportedTypeAttribute(attr):
     """Decorate the item to skip test unless Clang supports type __attribute__(attr)."""
     def compiler_doesnt_support_struct_attribute(self):
         compiler_path = self.getCompiler()
         f = tempfile.NamedTemporaryFile()
         cmd = [self.getCompiler(), "-x", "c++", "-c", "-o", f.name, "-"]
-        p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+        p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
         stdout, stderr = p.communicate('struct __attribute__((%s)) Test {};'%attr)
         if attr in stderr:
             return "Compiler does not support attribute %s"%(attr)
         return None
     return skipTestIfFn(compiler_doesnt_support_struct_attribute)
 
 def skipUnlessThreadSanitizer(func):
     """Decorate the item to skip test unless Clang -fsanitize=thread is supported."""
def is_compiler_clang_with_thread_sanitizer(self):
         return None
     return skipTestIfFn(is_compiler_clang_with_thread_sanitizer)(func)
 
 def skipUnlessUndefinedBehaviorSanitizer(func):
     """Decorate the item to skip test unless -fsanitize=undefined is supported."""
 
     def is_compiler_clang_with_ubsan(self):
         # Write out a temp file which exhibits UB.
-        inputf = tempfile.NamedTemporaryFile(suffix='.c')
+        inputf = tempfile.NamedTemporaryFile(suffix='.c', mode='w')
         inputf.write('int main() { int x = 0; return x / x; }\n')
         inputf.flush()
 
         # We need to write out the object into a named temp file for inspection.
         outputf = tempfile.NamedTemporaryFile()
 
         # Try to compile with ubsan turned on.
         cmd = '%s -fsanitize=undefined %s -o %s' % (self.getCompiler(), inputf.name, outputf.name)

lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py

class LinuxCoreTestCase(TestBase):
     _ppc64le_regions = 2
 
     def setUp(self):
         super(LinuxCoreTestCase, self).setUp()
         self._initial_platform = lldb.DBG.GetSelectedPlatform()
 
     def tearDown(self):
         lldb.DBG.SetSelectedPlatform(self._initial_platform)
         super(LinuxCoreTestCase, self).tearDown()
 
     @skipIf(oslist=['windows'])
     @skipIf(triple='^mips')
     def test_i386(self):
         """Test that lldb can read the process information from an i386 linux core file."""
         self.do_test("linux-i386", self._i386_pid, self._i386_regions, "a.out")
 
+    @skipIf(oslist=['windows'])
     def test_mips_o32(self):
         """Test that lldb can read the process information from an MIPS O32 linux core file."""
         self.do_test("linux-mipsel-gnuabio32", self._mips_o32_pid,
                 self._mips_regions, "linux-mipsel-gn")
 
+    @skipIf(oslist=['windows'])
     def test_mips_n32(self):
         """Test that lldb can read the process information from an MIPS N32 linux core file """
         self.do_test("linux-mips64el-gnuabin32", self._mips64_n32_pid,
                 self._mips_regions, "linux-mips64el-")
 
+    @skipIf(oslist=['windows'])
     def test_mips_n64(self):
         """Test that lldb can read the process information from an MIPS N64 linux core file """
         self.do_test("linux-mips64el-gnuabi64", self._mips64_n64_pid,
                 self._mips_regions, "linux-mips64el-")
 
     @skipIf(oslist=['windows'])
     @skipIf(triple='^mips')
     def test_ppc64le(self):
         """Test that lldb can read the process information from an ppc64le linux core file."""
         self.do_test("linux-ppc64le", self._ppc64le_pid, self._ppc64le_regions,
                 "linux-ppc64le.ou")
 
     @skipIf(oslist=['windows'])
     @skipIf(triple='^mips')
     def test_x86_64(self):
         """Test that lldb can read the process information from an x86_64 linux core file."""

lldb/trunk/packages/Python/lldbsuite/test/python_api/hello_world/main.c

 #include <stdio.h>
+#ifdef _MSC_VER
+#include <windows.h>
+#define sleep(x) Sleep((x) * 1000)
+#else
 #include <unistd.h>
+#endif
+
 int main(int argc, char const *argv[])
 {
     lldb_enable_attach();
 
     printf("Hello world.\n"); // Set break point at this line.
     if (argc == 1)
         return 0;
 
     // Waiting to be attached by the debugger, otherwise.
     char line[100];
     while (1) 
         sleep (1); // Waiting to be attached...
 
     printf("Exiting now\n");
 }