This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Don't warn about unused inputs in config files
ClosedPublic

Authored by mstorsjo on Apr 30 2018, 1:40 PM.

Details

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 30 2018, 1:40 PM
sepavloff accepted this revision.May 2 2018, 12:15 AM

Indeed, this is a missing case. Thank you for fixing it!

LGTM

This revision is now accepted and ready to land.May 2 2018, 12:15 AM
mstorsjo updated this revision to Diff 144839.May 2 2018, 1:50 AM

In order not to break test/Driver/cl-pch.cpp (I hadn't run the full testsuite for this change before submitting the patch), I had to do another tweak, in order not to claim any input argument after --. Does it still sound ok to you @sepavloff?

@sepavloff - does the additional change to this one also look fine to you?

sepavloff accepted this revision.May 3 2018, 9:50 PM

With additional changes the fix is OK.

LGTM.

This revision was automatically updated to reflect the committed changes.