This is an archive of the discontinued LLVM Phabricator instance.

Move to new C++ binding interface that requires isl::quota annotations [RFC]
Needs ReviewPublic

Authored by grosser on Apr 29 2018, 12:48 AM.

Event Timeline

grosser created this revision.Apr 29 2018, 12:48 AM

I think this diff is too large and should be split into at least two parts:

  1. The implementation of isl::quota, and possibly a small unittest showcasing how it's intended to be used
  2. Update of the APIs

Could you add a paragraph about what (and) this is trying to accomplish into the summary? Even better, add documentation?

What's your plan to converge this to/with an official isl C++ binding?

Prepend the title with [Polly].

Virtual destructors are a quite heavy machinery. Are you sure it is worth adding/are there alternatives?

But I very much like the idea of fast-failing on out-of-quota! Should we generalize this to all kind of errors?

lib/External/isl/include/isl/isl-noexceptions.h
62

what's the code style here?

106

Who is "I"? The author of this line (i.e. @grosser)? I think what is meant is somebody who uses quota_unclear in their code, although it seems it is not meant to be used directly.

lib/External/isl/isl_ctx.c
115

Forgotten/leftover?