Existing DAG combine only handles conversions for:
`{ FP_TO_SINT (f32, f64) } x { i32, i16 }
This patch simplifies the code to handle:
`{ FP_TO_SINT, FP_TO_UINT } x { f64, f32 } x { i64, i32, i16, i8 }`
Paths
| Differential D46102
[PowerPC] Unify handling for conversion of FP_TO_INT feeding a store ClosedPublic Authored by lei on Apr 25 2018, 8:14 PM.
Details Summary Existing DAG combine only handles conversions for: `{ FP_TO_SINT (f32, f64) } x { i32, i16 } This patch simplifies the code to handle: `{ FP_TO_SINT, FP_TO_UINT } x { f64, f32 } x { i64, i32, i16, i8 }`
Diff Detail Event TimelineComment Actions The code changes required are minor, but there's a few so I'd prefer to see another review of this patch.
This revision now requires changes to proceed.May 7 2018, 5:31 AM
Comment Actions Thanks for addressing everything so quickly. LGTM.
This revision is now accepted and ready to land.May 7 2018, 7:31 PM Closed by commit rL331778: [PowerPC] Unify handling for conversion of FP_TO_INT feeding a store (authored by lei). · Explain WhyMay 8 2018, 10:40 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 144054 lib/Target/PowerPC/PPCISelLowering.h
lib/Target/PowerPC/PPCISelLowering.cpp
lib/Target/PowerPC/PPCInstrInfo.td
lib/Target/PowerPC/PPCInstrVSX.td
test/CodeGen/PowerPC/store_fptoi.ll
|
Hmm... turns out the names are pretty long. Please drop the CV_ prefix from both.