Page MenuHomePhabricator

[GlobalISel][InstructionSelect] Refactoring out a getMatchTable virtual method, NFC

Authored by rtereshin on Apr 25 2018, 5:12 PM.



to share it between the Instruction Selector and the Testgen both.

Originally part of the larger ([GlobalISel][utils] Adding the init version of Instruction Select Testgen) patch, extracted as to make it smaller and more targeted.

Partially reviewed by @dsanders within the patch mentioned.

Required by

Diff Detail


Event Timeline

rtereshin created this revision.Apr 25 2018, 5:12 PM
dsanders accepted this revision.May 1 2018, 11:15 AM

The NFC changes look good to me but the commit message (particularly the subject line) doesn't really match the content. LGTM with a better commit message.

This revision is now accepted and ready to land.May 1 2018, 11:15 AM


I'm thinking on the following message:

[GlobalISel][InstructionSelect] Refactoring out a getMatchTable virtual method + NFC

The main goal is to share getMatchTable between the Instruction
Selector and the Testgen.

The commit also contains some NFC only loosely related to refactoring
out the getMatchTable, but strongly related to the initial Testgen
patch (see

Reviewers: dsanders, aemerson

Reviewed By: dsanders

Subscribers: rovka, kristof.beyls, llvm-commits, dsanders

Differential Revision:

Thanks. I'd suggest making it a little more obvious to someone skim-reading the list, for example:

[GlobalISel][InstructionSelect] Refactoring out a getMatchTable virtual method + other small NFC's

but LGTM either way.

This revision was automatically updated to reflect the committed changes.