This is an archive of the discontinued LLVM Phabricator instance.

[X86] movdiri and movdir64b instructions
ClosedPublic

Authored by GBuella on Apr 23 2018, 1:12 PM.

Diff Detail

Event Timeline

GBuella created this revision.Apr 23 2018, 1:12 PM
craig.topper added inline comments.Apr 23 2018, 2:11 PM
lib/Support/Host.cpp
1270

Drop the comment and put these bit checks with the other Leaf7 ECX bit checks above.

lib/Target/X86/X86InstrMovdir.td
1 ↗(On Diff #143628)

I don't know that a new file is warranted for so few instructions. Just add them to X86InstrInfo.td

GBuella updated this revision to Diff 143658.Apr 23 2018, 2:48 PM
GBuella marked 2 inline comments as done.
craig.topper added inline comments.Apr 23 2018, 5:26 PM
test/CodeGen/X86/movdir-intrinsic.ll
1

How about movdir-intrinsic-x86.ll

test/CodeGen/X86/movdirq-intrinsic.ll
1

How about movdir-intrinsic-x86_64.ll

GBuella updated this revision to Diff 143717.Apr 24 2018, 5:44 AM
RKSimon added inline comments.Apr 24 2018, 7:03 AM
lib/Target/X86/X86InstrInfo.td
2700

Please can you add scheduling classes

GBuella updated this revision to Diff 143897.Apr 25 2018, 3:47 AM
GBuella marked an inline comment as done.

No more comments from me - @craig.topper are you happy with this?

This revision is now accepted and ready to land.Apr 30 2018, 9:41 AM
This revision was automatically updated to reflect the committed changes.