This is an archive of the discontinued LLVM Phabricator instance.

Differential D45936

update readability-identifier-naming-objc test to use interface ivar. Implementation ivars are not supported in 32-bits OS.
ClosedPublic

Authored by Wizard on Apr 22 2018, 5:42 PM.

Details

Reviewers
alexfh
chandlerc
Commits
rGf2876e338585: update readability-identifier-naming-objc test to use interface ivar.
rL330562: update readability-identifier-naming-objc test to use interface ivar.
rCTE330562: update readability-identifier-naming-objc test to use interface ivar.

Diff Detail

Event Timeline

Wizard created this revision.Apr 22 2018, 5:42 PM
Herald added subscribers: cfe-commits, klimek. · View Herald TranscriptApr 22 2018, 5:42 PM
Harbormaster completed remote builds in B17316: Diff 143496.Apr 22 2018, 5:42 PM
Wizard added reviewers: alexfh, chandlerc.Apr 22 2018, 5:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2018, 6:08 PM
Closed by commit rCTE330562: update readability-identifier-naming-objc test to use interface ivar. (authored by Wizard). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
clang-tidy/
7 lines

Diff 143496

test/clang-tidy/readability-identifier-naming-objc.m

// RUN: %check_clang_tidy %s readability-identifier-naming %t \ // RUN: %check_clang_tidy %s readability-identifier-naming %t \
// RUN: -config='{CheckOptions: \ // RUN: -config='{CheckOptions: \
// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \ // RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \
// RUN: -- // RUN: --
@interface Foo @interface Foo {
@end
@implementation Foo {
int _bar; int _bar;
int barWithoutPrefix; int barWithoutPrefix;
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for objc ivar 'barWithoutPrefix' [readability-identifier-naming] // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for objc ivar 'barWithoutPrefix' [readability-identifier-naming]
// CHECK-FIXES: int _barWithoutPrefix; // CHECK-FIXES: int _barWithoutPrefix;
} }
@end @end