Page MenuHomePhabricator

Convert clang-interpreter to ORC JIT API
ClosedPublic

Authored by sas on Apr 20 2018, 12:47 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sas created this revision.Apr 20 2018, 12:47 PM
alexander-shaposhnikov added inline comments.
examples/clang-interpreter/main.cpp
52 ↗(On Diff #143367)

not needed

84 ↗(On Diff #143367)

const TargetMachine & ?

93 ↗(On Diff #143367)

const string & or maybe even StringRef and the same below

sas added inline comments.Apr 20 2018, 1:13 PM
examples/clang-interpreter/main.cpp
52 ↗(On Diff #143367)

Seems cleaner to me to have these explicit, and avoids potentiel code churn if there are changes above. Is there something in the llvm coding style that recommends skipping these?

sas updated this revision to Diff 143376.Apr 20 2018, 1:34 PM

Review comments from @alexshap.

lhames accepted this revision.May 23 2018, 4:24 PM

Looks good to me. :)

This revision is now accepted and ready to land.May 23 2018, 4:24 PM
This revision was automatically updated to reflect the committed changes.